minor #26706 [Messenger] Make NoHandlerForMessageException a logic exception (ogizanagi)

fabpot · fabpot · commit 6f15386b89df · 2018-03-30T09:58:18.000+02:00
This PR was merged into the 4.1-dev branch. Discussion ---------- [Messenger] Make NoHandlerForMessageException a logic exception | Q | A | ------------- | --- | Branch? | master  | Bug fix? | no | New feature? | no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | #26648 (comment)  | License | MIT | Doc PR | N/A  To me, a missing handler for a message is a program logic exception (or misconfiguration). Even if it's only detected at runtime here. It's the same as `ServiceNotFoundException` which even is an `\InvalidArgumentException`. Could eventually also be the case here. Commits ------- 0489bbd [Messenger] Make NoHandlerForMessageException a logic exception
diff --git a/src/Symfony/Component/Messenger/Exception/NoHandlerForMessageException.php b/src/Symfony/Component/Messenger/Exception/NoHandlerForMessageException.php
@@ -14,6 +14,6 @@
 /**
  * @author Samuel Roze <samuel.roze@gmail.com>
  */
-class NoHandlerForMessageException extends \RuntimeException implements ExceptionInterface
+class NoHandlerForMessageException extends \LogicException implements ExceptionInterface
 {
 }

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,6 @@`
`14`	`14`	`/**`
`15`	`15`	`* @author Samuel Roze <samuel.roze@gmail.com>`
`16`	`16`	`*/`
`17`		`-class NoHandlerForMessageException extends \RuntimeException implements ExceptionInterface`
	`17`	`+class NoHandlerForMessageException extends \LogicException implements ExceptionInterface`
`18`	`18`	`{`
`19`	`19`	`}`