bug #19579 [Process] Strengthen Windows pipe files opening (again...) (nicolas-grekas)

fabpot · fabpot · commit 6f1055057416 · 2016-08-13T11:38:39.000-07:00
This PR was merged into the 2.7 branch. Discussion ---------- [Process] Strengthen Windows pipe files opening (again...) | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19336 | License | MIT | Doc PR | - A nightmare... See https://ci.appveyor.com/project/fabpot/symfony/build/1.0.11427#L965 Commits ------- a7a2d16 [Process] Strengthen Windows pipe files opening (again...)
diff --git a/src/Symfony/Component/Process/Pipes/WindowsPipes.php b/src/Symfony/Component/Process/Pipes/WindowsPipes.php
@@ -51,17 +51,22 @@ public function __construct($disableOutput, $input)
                 Process::STDOUT => Process::OUT,
                 Process::STDERR => Process::ERR,
             );
+            $tmpCheck = false;
             $tmpDir = sys_get_temp_dir();
-            $error = 'unknown reason';
-            set_error_handler(function ($type, $msg) use (&$error) { $error = $msg; });
+            $lastError = 'unknown reason';
+            set_error_handler(function ($type, $msg) use (&$lastError) { $lastError = $msg; });
             for ($i = 0;; ++$i) {
                 foreach ($pipes as $pipe => $name) {
                     $file = sprintf('%s\\sf_proc_%02X.%s', $tmpDir, $i, $name);
                     if (file_exists($file) && !unlink($file)) {
                         continue 2;
                     }
                     $h = fopen($file, 'xb');
-                    if (!$h && false === strpos($error, 'File exists')) {
+                    if (!$h) {
+                        $error = $lastError;
+                        if ($tmpCheck || $tmpCheck = unlink(tempnam(false, 'sf_check_'))) {
+                            continue;
+                        }
                         restore_error_handler();
                         throw new RuntimeException(sprintf('A temporary file could not be opened to write the process output: %s', $error));
                     }
