bug #38682 [HttpClient] never trace content of event-stream responses (nicolas-grekas)

Nyholm · Nyholm · commit 6f0a8971fd31 · 2020-10-22T18:54:44.000+02:00
This PR was merged into the 5.x branch. Discussion ---------- [HttpClient] never trace content of event-stream responses | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Let's leverage #38587 in `EventSourceHttpClient` Commits ------- e4c0262 [HttpClient] never trace content of event-stream responses
diff --git a/src/Symfony/Component/HttpClient/EventSourceHttpClient.php b/src/Symfony/Component/HttpClient/EventSourceHttpClient.php
@@ -60,6 +60,10 @@ public function request(string $method, string $url, array $options = []): Respo
 
         if ($accept = self::normalizeHeaders($options['headers'] ?? [])['accept'] ?? []) {
             $state->buffer = \in_array($accept, [['Accept: text/event-stream'], ['accept: text/event-stream']], true) ? '' : null;
+
+            if (null !== $state->buffer) {
+                $options['extra']['trace_content'] = false;
+            }
         }
 
         return new AsyncResponse($this->client, $method, $url, $options, static function (ChunkInterface $chunk, AsyncContext $context) use ($state, $method, $url, $options) {

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,10 @@ public function request(string $method, string $url, array $options = []): Respo`
`60`	`60`
`61`	`61`	`if ($accept = self::normalizeHeaders($options['headers'] ?? [])['accept'] ?? []) {`
`62`	`62`	`$state->buffer = \in_array($accept, [['Accept: text/event-stream'], ['accept: text/event-stream']], true) ? '' : null;`
	`63`	`+`
	`64`	`+ if (null !== $state->buffer) {`
	`65`	`+ $options['extra']['trace_content'] = false;`
	`66`	`+ }`
`63`	`67`	`}`
`64`	`68`
`65`	`69`	`return new AsyncResponse($this->client, $method, $url, $options, static function (ChunkInterface $chunk, AsyncContext $context) use ($state, $method, $url, $options) {`