feature #58512 [Validator] Pass context to expressions used in When constraints (KoNekoD)

fabpot · fabpot · commit 6e9c993d765a · 2024-10-10T07:26:42.000+02:00
This PR was squashed before being merged into the 7.2 branch. Discussion ---------- [Validator] Pass context to expressions used in `When` constraints | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | Fix #58511 | License | MIT I encountered a problem with validation of nested entities and I needed to validate by parent field, if draft true then no validation is needed Commits ------- f05ce63 [Validator] Pass context to expressions used in `When` constraints
diff --git a/src/Symfony/Component/Validator/CHANGELOG.md b/src/Symfony/Component/Validator/CHANGELOG.md
@@ -12,6 +12,7 @@ CHANGELOG
  * Add the `WordCount` constraint
  * Add the `Week` constraint
  * Add `CompoundConstraintTestCase` to ease testing Compound Constraints
+ * Add context variable to `WhenValidator`
 
 7.1
 ---
diff --git a/src/Symfony/Component/Validator/Constraints/WhenValidator.php b/src/Symfony/Component/Validator/Constraints/WhenValidator.php
@@ -33,6 +33,7 @@ public function validate(mixed $value, Constraint $constraint): void
         $variables = $constraint->values;
         $variables['value'] = $value;
         $variables['this'] = $context->getObject();
+        $variables['context'] = $context;
 
         if ($this->getExpressionLanguage()->evaluate($constraint->expression, $variables)) {
             $context->getValidator()->inContext($context)
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/WhenValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/WhenValidatorTest.php
@@ -85,6 +85,31 @@ public function testConstraintsAreExecutedWithObject()
         ]));
     }
 
+    public function testConstraintsAreExecutedWithNestedObject()
+    {
+        $parent = new \stdClass();
+        $parent->child = new \stdClass();
+        $parent->ok = true;
+
+        $number = new \stdClass();
+        $number->value = 1;
+
+        $this->setObject($parent);
+        $this->setPropertyPath('child.value');
+        $this->setRoot($parent);
+
+        $constraints = [
+            new PositiveOrZero(),
+        ];
+
+        $this->expectValidateValue(0, $number->value, $constraints);
+
+        $this->validator->validate($number->value, new When([
+            'expression' => 'context.getRoot().ok === true',
+            'constraints' => $constraints,
+        ]));
+    }
+
     public function testConstraintsAreExecutedWithValue()
     {
         $constraints = [
