fix tests on PHP 5

xabbuh · xabbuh · commit 6d84aeb13168 · 2019-01-05T13:04:54.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/ResolveNamedArgumentsPassTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/ResolveNamedArgumentsPassTest.php
@@ -119,7 +119,7 @@ public function testArgumentNotFound()
 
     /**
      * @expectedException \Symfony\Component\DependencyInjection\Exception\InvalidArgumentException
-     * @expectedExceptionMessage Invalid service "Symfony\Component\DependencyInjection\Tests\Fixtures\TestDefinition1": method "Symfony\Component\DependencyInjection\Tests\Fixtures\FactoryDummy::create()" has no argument named "$notFound". Check your service definition.
+     * @expectedExceptionMessage Invalid service "Symfony\Component\DependencyInjection\Tests\Fixtures\TestDefinition1": method "Symfony\Component\DependencyInjection\Tests\Fixtures\FactoryDummy::createTestDefinition1()" has no argument named "$notFound". Check your service definition.
      */
     public function testCorrectMethodReportedInException()
     {
@@ -128,7 +128,7 @@ public function testCorrectMethodReportedInException()
         $container->register(FactoryDummy::class, FactoryDummy::class);
 
         $definition = $container->register(TestDefinition1::class, TestDefinition1::class);
-        $definition->setFactory(array(FactoryDummy::class, 'create'));
+        $definition->setFactory(array(FactoryDummy::class, 'createTestDefinition1'));
         $definition->setArguments(array('$notFound' => '123'));
 
         $pass = new ResolveNamedArgumentsPass();
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/FactoryDummy.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/FactoryDummy.php
@@ -33,6 +33,10 @@ public static function createSelf(): self
     public static function createParent(): parent
     {
     }
+
+    public function createTestDefinition1()
+    {
+    }
 }
 
 class FactoryParent

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,10 @@ public static function createSelf(): self`
`33`	`33`	`public static function createParent(): parent`
`34`	`34`	`{`
`35`	`35`	`}`
	`36`	`+`
	`37`	`+ public function createTestDefinition1()`
	`38`	`+ {`
	`39`	`+ }`
`36`	`40`	`}`
`37`	`41`
`38`	`42`	`class FactoryParent`