8000 feature #45476 [HttpKernel] Deprecate StreamedResponseListener, it se… · symfony/symfony@6d6b323 · GitHub
[go: up one dir, main page]
Skip to content

Commit 6d6b323

Browse files
fabpotfabpot
committed
feature #45476 [HttpKernel] Deprecate StreamedResponseListener, it serves no purpose anymore (nicolas-grekas)
This PR was merged into the 6.1 branch. Discussion ---------- [HttpKernel] Deprecate StreamedResponseListener, it serves no purpose anymore | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | - | License | MIT | Doc PR | - `StreamedResponseListener` has been introduced at the same time as `StreamedResponse` in #2935. Its purpose was to make catching exceptions easier by wrapping the call to `$response->send()` in the main try/catch of `HttpKernel`. Since #12998, we have `HttpKernel::terminateWithException()`, and we don't need that anymore, so we can just remove the listener. This will help [integrate Symfony into e.g. Swoole](php-runtime/runtime#115) /cc @alexander-schranz. Commits ------- ee61774 [HttpKernel] Deprecate StreamedResponseListener, it serves no purpose anymore
2 parents 2d723e1 + ee61774 commit 6d6b323

File tree

5 files changed

+11
-5
lines changed

5 files changed

+11
-5
lines changed

‎UPGRADE-6.1.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ Console
1212

1313
* Deprecate `Command::$defaultName` and `Command::$defaultDescription`, use the `AsCommand` attribute instead
1414

15+
HttpKernel
16+
----------
17+
18+
* Deprecate StreamedResponseListener, it's not needed anymore
19+
1520
Serializer
1621
----------
1722

‎src/Symfony/Bundle/FrameworkBundle/Resources/config/web.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
use Symfony\Component\HttpKernel\EventListener\ErrorListener;
2727
use Symfony\Component\HttpKernel\EventListener\LocaleListener;
2828
use Symfony\Component\HttpKernel\EventListener\ResponseListener;
29-
use Symfony\Component\HttpKernel\EventListener\StreamedResponseListener;
3029
use Symfony\Component\HttpKernel\EventListener\ValidateRequestListener;
3130

3231
return static function (ContainerConfigurator $container) {
@@ -79,9 +78,6 @@
7978
])
8079
->tag('kernel.event_subscriber')
8180

82-
->set('streamed_response_listener', StreamedResponseListener::class)
83-
->tag('kernel.event_subscriber')
84-
8581
->set('locale_listener', LocaleListener::class)
8682
->args([
8783
service('request_stack'),

‎src/Symfony/Component/HttpKernel/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ CHANGELOG
55
---
66

77
* Add `BackedEnumValueResolver` to resolve backed enum cases from request attributes in controller arguments
8+
* Deprecate StreamedResponseListener, it's not needed anymore
89

910
6.0
1011
---

‎src/Symfony/Component/HttpKernel/EventListener/AbstractSessionListener.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ public static function getSubscribedEvents(): array
246246
{
247247
return [
248248
KernelEvents::REQUEST => ['onKernelRequest', 128],
249-
// low priority to come after regular response listeners, but higher than StreamedResponseListener
249+
// low priority to come after regular response listeners
250250
KernelEvents::RESPONSE => ['onKernelResponse', -1000],
251251
];
252252
}

‎src/Symfony/Component/HttpKernel/EventListener/StreamedResponseListener.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,17 @@
1616
use Symfony\Component\HttpKernel\Event\ResponseEvent;
1717
use Symfony\Component\HttpKernel\KernelEvents;
1818

19+
trigger_deprecation('symfony/http-kernel', '6.1', 'The "%s" class is deprecated.', StreamedResponseListener::class);
20+
1921
/**
2022
* StreamedResponseListener is responsible for sending the Response
2123
* to the client.
2224
*
2325
* @author Fabien Potencier <fabien@symfony.com>
2426
*
2527
* @final
28+
*
29+
* @deprecated since Symfony 6.1
2630
*/
2731
class StreamedResponseListener implements EventSubscriberInterface
2832
{

0 commit comments

Comments
 (0)
0