symfony
diff --git a/‎.github/expected-missing-return-types.diff
Lines changed: 81 additions & 81 deletions b/‎.github/expected-missing-return-types.diff
Lines changed: 81 additions & 81 deletions
diff --git a/‎UPGRADE-7.0.md
Lines changed: 7 additions & 0 deletions b/‎UPGRADE-7.0.md
Lines changed: 7 additions & 0 deletions
diff --git a/‎src/Symfony/Component/Console/Application.php
Lines changed: 1 addition & 13 deletions b/‎src/Symfony/Component/Console/Application.php
Lines changed: 1 addition & 13 deletions
diff --git a/‎src/Symfony/Component/Console/CHANGELOG.md
Lines changed: 7 additions & 0 deletions b/‎src/Symfony/Component/Console/CHANGELOG.md
Lines changed: 7 additions & 0 deletions
diff --git a/‎src/Symfony/Component/Console/Command/Command.php
Lines changed: 7 additions & 52 deletions b/‎src/Symfony/Component/Console/Command/Command.php
Lines changed: 7 additions & 52 deletions
diff --git a/‎src/Symfony/Component/Console/Command/CompleteCommand.php
Lines changed: 0 additions & 10 deletions b/‎src/Symfony/Component/Console/Command/CompleteCommand.php
Lines changed: 0 additions & 10 deletions
diff --git a/‎src/Symfony/Component/Console/Command/DumpCompletionCommand.php
Lines changed: 0 additions & 10 deletions b/‎src/Symfony/Component/Console/Command/DumpCompletionCommand.php
Lines changed: 0 additions & 10 deletions
diff --git a/‎src/Symfony/Component/Console/Command/LazyCommand.php
Lines changed: 3 additions & 8 deletions b/‎src/Symfony/Component/Console/Command/LazyCommand.php
Lines changed: 3 additions & 8 deletions
diff --git a/‎src/Symfony/Component/Console/Command/SignalableCommandInterface.php
Lines changed: 1 addition & 3 deletions b/‎src/Symfony/Component/Console/Command/SignalableCommandInterface.php
Lines changed: 1 addition & 3 deletions
diff --git a/‎src/Symfony/Component/Console/Formatter/NullOutputFormatterStyle.php
Lines changed: 2 additions & 8 deletions b/‎src/Symfony/Component/Console/Formatter/NullOutputFormatterStyle.php
Lines changed: 2 additions & 8 deletions
diff --git a/‎src/Symfony/Component/Console/Formatter/OutputFormatterStyle.php
Lines changed: 2 additions & 8 deletions b/‎src/Symfony/Component/Console/Formatter/OutputFormatterStyle.php
Lines changed: 2 additions & 8 deletions
diff --git a/‎src/Symfony/Component/Console/Helper/Helper.php
Lines changed: 1 addition & 4 deletions b/‎src/Symfony/Component/Console/Helper/Helper.php
Lines changed: 1 addition & 4 deletions
diff --git a/‎src/Symfony/Component/Console/Input/InputArgument.php
Lines changed: 1 addition & 4 deletions b/‎src/Symfony/Component/Console/Input/InputArgument.php
Lines changed: 1 addition & 4 deletions
diff --git a/‎src/Symfony/Component/Console/Input/InputOption.php
Lines changed: 1 addition & 4 deletions b/‎src/Symfony/Component/Console/Input/InputOption.php
Lines changed: 1 addition & 4 deletions
diff --git a/‎src/Symfony/Component/Console/Input/StringInput.php
Lines changed: 0 additions & 4 deletions b/‎src/Symfony/Component/Console/Input/StringInput.php
Lines changed: 0 additions & 4 deletions
diff --git a/‎src/Symfony/Component/Console/Question/Question.php
Lines changed: 2 additions & 8 deletions b/‎src/Symfony/Component/Console/Question/Question.php
Lines changed: 2 additions & 8 deletions
@@ -10,6 +10,13 @@ Cache
 
  * Add parameter `$isSameDatabase` to `DoctrineDbalAdapter::configureSchema()`
 
+Console
+-------
+
+ * Remove `Command::$defaultName` and `Command::$defaultDescription`, use the `AsCommand` attribute instead
+ * Passing null to `*Command::setApplication()`, `*FormatterStyle::setForeground/setBackground()`, `Helper::setHelpSet()`, `Input*::setDefault()` and `Question::setAutocompleterCallback/setValidator()` must be done explicitly
+ * Remove `StringInput::REGEX_STRING`
+
 DoctrineBridge
 --------------
 
 
@@ -1026,11 +1026,6 @@ protected function doRunCommand(Command $command, InputInterface $input, OutputI
                         // If the command is signalable, we call the handleSignal() method
                         if (\in_array($signal, $commandSignals, true)) {
                             $exitCode = $command->handleSignal($signal, $exitCode);
-                            // BC layer for Symfony <= 5
-                            if (null === $exitCode) {
-                                trigger_deprecation('symfony/console', '6.3', 'Not returning an exit code from "%s::handleSignal()" is deprecated, return "false" to keep the command running or "0" to exit successfully.', get_debug_type($command));
-                                $exitCode = 0;
-                            }
                         }
 
                         if (false !== $exitCode) {
@@ -1045,14 +1040,7 @@ protected function doRunCommand(Command $command, InputInterface $input, OutputI
 
             foreach ($commandSignals as $signal) {
                 $this->signalRegistry->register($signal, function (int $signal) use ($command): void {
-                    $exitCode = $command->handleSignal($signal);
-                    // BC layer for Symfony <= 5
-                    if (null === $exitCode) {
-                        trigger_deprecation('symfony/console', '6.3', 'Not returning an exit code from "%s::handleSignal()" is deprecated, return "false" to keep the command running or "0" to exit successfully.', get_debug_type($command));
-                        $exitCode = 0;
-                    }
-
-                    if (false !== $exitCode) {
+                    if (false !== $exitCode = $command->handleSignal($signal)) {
                         exit($exitCode);
                     }
                 });
 
@@ -1,6 +1,13 @@
 CHANGELOG
 =========
 
+7.0
+---
+
+ * Remove `Command::$defaultName` and `Command::$defaultDescription`, use the `AsCommand` attribute instead
+ * Passing null to `*Command::setApplication()`, `*FormatterStyle::setForeground/setBackground()`, `Helper::setHelpSet()`, `Input*::setDefault()` and `Question::setAutocompleterCallback/setValidator()` must be done explicitly
+ * Remove `StringInput::REGEX_STRING`
+
 6.4
 ---
 
 
@@ -39,20 +39,6 @@ class Command
     public const FAILURE = 1;
     public const INVALID = 2;
 
-    /**
-     * @var string|null The default command name
-     *
-     * @deprecated since Symfony 6.1, use the AsCommand attribute instead
-     */
-    protected static $defaultName;
-
-    /**
-     * @var string|null The default command description
-     *
-     * @deprecated since Symfony 6.1, use the AsCommand attribute instead
-     */
-    protected static $defaultDescription;
-
     private ?Application $application = null;
     private ?string $name = null;
     private ?string $processTitle = null;
@@ -70,40 +56,20 @@ class Command
 
     public static function getDefaultName(): ?string
     {
-        $class = static::class;
-
-        if ($attribute = (new \ReflectionClass($class))->getAttributes(AsCommand::class)) {
+        if ($attribute = (new \ReflectionClass(static::class))->getAttributes(AsCommand::class)) {
             return $attribute[0]->newInstance()->name;
         }
 
-        $r = new \ReflectionProperty($class, 'defaultName');
-
-        if ($class !== $r->class || null === static::$defaultName) {
-            return null;
-        }
-
-        trigger_deprecation('symfony/console', '6.1', 'Relying on the static property "$defaultName" for setting a command name is deprecated. Add the "%s" attribute to the "%s" class instead.', AsCommand::class, static::class);
-
-        return static::$defaultName;
+        return null;
     }
 
     public static function getDefaultDescription(): ?string
     {
-        $class = static::class;
-
-        if ($attribute = (new \ReflectionClass($class))->getAttributes(AsCommand::class)) {
+        if ($attribute = (new \ReflectionClass(static::class))->getAttributes(AsCommand::class)) {
             return $attribute[0]->newInstance()->description;
         }
 
-        $r = new \ReflectionProperty($class, 'defaultDescription');
-
-        if ($class !== $r->class || null === static::$defaultDescription) {
-            return null;
-        }
-
-        trigger_deprecation('symfony/console', '6.1', 'Relying on the static property "$defaultDescription" for setting a command description is deprecated. Add the "%s" attribute to the "%s" class instead.', AsCommand::class, static::class);
-
-        return static::$defaultDescription;
+        return null;
     }
 
     /**
@@ -152,11 +118,8 @@ public function ignoreValidationErrors()
     /**
      * @return void
      */
-    public function setApplication(Application $application = null)
+    public function setApplication(?Application $application)
     {
-        if (1 > \func_num_args()) {
-            trigger_deprecation('symfony/console', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);
-        }
         $this->application = $application;
         if ($application) {
             $this->setHelperSet($application->getHelperSet());
@@ -460,12 +423,8 @@ public function getNativeDefinition(): InputDefinition
      *
      * @throws InvalidArgumentException When argument mode is not valid
      */
-    public function addArgument(string $name, int $mode = null, string $description = '', mixed $default = null /* array|\Closure $suggestedValues = null */): static
+    public function addArgument(string $name, int $mode = null, string $description = '', mixed $default = null, array|\Closure $suggestedValues = []): static
     {
-        $suggestedValues = 5 <= \func_num_args() ? func_get_arg(4) : [];
-        if (!\is_array($suggestedValues) && !$suggestedValues instanceof \Closure) {
-            throw new \TypeError(sprintf('Argument 5 passed to "%s()" must be array or \Closure, "%s" given.', __METHOD__, get_debug_type($suggestedValues)));
-        }
         $this->definition->addArgument(new InputArgument($name, $mode, $description, $default, $suggestedValues));
         $this->fullDefinition?->addArgument(new InputArgument($name, $mode, $description, $default, $suggestedValues));
 
@@ -484,12 +443,8 @@ public function addArgument(string $name, int $mode = null, string $description
      *
      * @throws InvalidArgumentException If option mode is invalid or incompatible
      */
-    public function addOption(string $name, string|array $shortcut = null, int $mode = null, string $description = '', mixed $default = null /* array|\Closure $suggestedValues = [] */): static
+    public function addOption(string $name, string|array $shortcut = null, int $mode = null, string $description = '', mixed $default = null, array|\Closure $suggestedValues = []): static
     {
-        $suggestedValues = 6 <= \func_num_args() ? func_get_arg(5) : [];
-        if (!\is_array($suggestedValues) && !$suggestedValues instanceof \Closure) {
-            throw new \TypeError(sprintf('Argument 5 passed to "%s()" must be array or \Closure, "%s" given.', __METHOD__, get_debug_type($suggestedValues)));
-        }
         $this->definition->addOption(new InputOption($name, $shortcut, $mode, $description, $default, $suggestedValues));
         $this->fullDefinition?->addOption(new InputOption($name, $shortcut, $mode, $description, $default, $suggestedValues));
 
 
@@ -34,16 +34,6 @@ final class CompleteCommand extends Command
 {
     public const COMPLETION_API_VERSION = '1';
 
-    /**
-     * @deprecated since Symfony 6.1
-     */
-    protected static $defaultName = '|_complete';
-
-    /**
-     * @deprecated since Symfony 6.1
-     */
-    protected static $defaultDescription = 'Internal command to provide shell completion suggestions';
-
     private $completionOutputs;
 
     private $isDebug = false;
 
@@ -27,16 +27,6 @@
 #[AsCommand(name: 'completion', description: 'Dump the shell completion script')]
 final class DumpCompletionCommand extends Command
 {
-    /**
-     * @deprecated since Symfony 6.1
-     */
-    protected static $defaultName = 'completion';
-
-    /**
-     * @deprecated since Symfony 6.1
-     */
-    protected static $defaultDescription = 'Dump the shell completion script';
-
     private array $supportedShells;
 
     protected function configure(): void
 
@@ -45,11 +45,8 @@ public function ignoreValidationErrors(): void
         $this->getCommand()->ignoreValidationErrors();
     }
 
-    public function setApplication(Application $application = null): void
+    public function setApplication(?Application $application): void
     {
-        if (1 > \func_num_args()) {
-            trigger_deprecation('symfony/console', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);
-        }
         if ($this->command instanceof parent) {
             $this->command->setApplication($application);
         }
@@ -116,9 +113,8 @@ public function getNativeDefinition(): InputDefinition
     /**
      * @param array|\Closure(CompletionInput,CompletionSuggestions):list<string|Suggestion> $suggestedValues The values used for input completion
      */
-
public function addArgument(string $name, int $mode = null, string $description = '', mixed $default = null /* array|\Closure $suggestedValues = [] */): static    public function addArgument(string $name, int $mode = null, string $description = '', mixed $default = null /* array|\Closure $suggestedValues = [] */): static
+    public function addArgument(string $name, int $mode = null, string $description = '', mixed $default = null, array|\Closure $suggestedValues = []): static
     {
-        $suggestedValues = 5 <= \func_num_args() ? func_get_arg(4) : [];
         $this->getCommand()->addArgument($name, $mode, $description, $default, $suggestedValues);
 
         return $this;
@@ -127,9 +123,8 @@ public function addArgument(string $name, int $mode = null, string $description
     /**
      * @param array|\Closure(CompletionInput,CompletionSuggestions):list<string|Suggestion> $suggestedValues The values used for input completion
      */
-    public function addOption(string $name, string|array $shortcut = null, int $mode = null, string $description = '', mixed $default = null /* array|\Closure $suggestedValues = [] */): static
+    public function addOption(string $name, string|array $shortcut = null, int $mode = null, string $description = '', mixed $default = null, array|\Closure $suggestedValues = []): static
     {
-        $suggestedValues = 6 <= \func_num_args() ? func_get_arg(5) : [];
         $this->getCommand()->addOption($name, $shortcut, $mode, $description, $default, $suggestedValues);
 
         return $this;
 
@@ -26,9 +26,7 @@ public function getSubscribedSignals(): array;
     /**
      * The method will be called when the application is signaled.
      *
-     * @param int|false $previousExitCode
-
      * @return int|false The exit code to return or false to continue the normal execution
      */
-    public function handleSignal(int $signal, /* int|false $previousExitCode = 0 */);
+    public function handleSignal(int $signal, int|false $previousExitCode = 0);
 }
@@ -21,19 +21,13 @@ public function apply(string $text): string
         return $text;
     }
 
-    public function setBackground(string $color = null): void
+    public function setBackground(?string $color): void
     {
-        if (1 > \func_num_args()) {
-            trigger_deprecation('symfony/console', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);
-        }
         // do nothing
     }
 
-    public function setForeground(string $color = null): void
+    public function setForeground(?string $color): void
     {
-        if (1 > \func_num_args()) {
-            trigger_deprecation('symfony/console', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);
-        }
         // do nothing
     }
 
 
@@ -41,22 +41,16 @@ public function __construct(string $foreground = null, string $background = null
     /**
      * @return void
      */
-    public function setForeground(string $color = null)
+    public function setForeground(?string $color)
     {
-        if (1 > \func_num_args()) {
-            trigger_deprecation('symfony/console', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);
-        }
         $this->color = new Color($this->foreground = $color ?: '', $this->background, $this->options);
     }
 
     /**
      * @return void
      */
-    public function setBackground(string $color = null)
+    public function setBackground(?string $color)
     {
-        if (1 > \func_num_args()) {
-            trigger_deprecation('symfony/console', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);
-        }
         $this->color = new Color($this->foreground, $this->background = $color ?: '', $this->options);
     }
 
 
@@ -26,11 +26,8 @@ abstract class Helper implements HelperInterface
     /**
      * @return void
      */
-    public function setHelperSet(HelperSet $helperSet = null)
+    public function setHelperSet(?HelperSet $helperSet)
     {
-        if (1 > \func_num_args()) {
-            trigger_deprecation('symfony/console', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);
-        }
         $this->helperSet = $helperSet;
     }
 
 
@@ -95,11 +95,8 @@ public function isArray(): bool
      *
      * @throws LogicException When incorrect default value is given
      */
-    public function setDefault(string|bool|int|float|array $default = null)
+    public function setDefault(string|bool|int|float|array|null $default)
     {
-        if (1 > \func_num_args()) {
-            trigger_deprecation('symfony/console', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);
-        }
         if ($this->isRequired() && null !== $default) {
             throw new LogicException('Cannot set a default value except for InputArgument::OPTIONAL mode.');
         }
 
@@ -181,11 +181,8 @@ public function isNegatable(): bool
     /**
      * @return void
      */
-    public function setDefault(string|bool|int|float|array $default = null)
+    public function setDefault(string|bool|int|float|array|null $default)
     {
-        if (1 > \func_num_args()) {
-            trigger_deprecation('symfony/console', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);
-        }
         if (self::VALUE_NONE === (self::VALUE_NONE & $this->mode) && null !== $default) {
             throw new LogicException('Cannot set a default value when using InputOption::VALUE_NONE mode.');
         }
 
@@ -24,10 +24,6 @@
  */
 class StringInput extends ArgvInput
 {
-    /**
-     * @deprecated since Symfony 6.1
-     */
-    public const REGEX_STRING = '([^\s]+?)(?:\s|(?<!\\\\)"|(?<!\\\\)\'|$)';
     public const REGEX_UNQUOTED_STRING = '([^\s\\\\]+?)';
     public const REGEX_QUOTED_STRING = '(?:"([^"\\\\]*(?:\\\\.[^"\\\\]*)*)"|\'([^\'\\\\]*(?:\\\\.[^\'\\\\]*)*)\')';
 
 
@@ -175,11 +175,8 @@ public function getAutocompleterCallback(): ?callable
      *
      * @return $this
      */
-    public function setAutocompleterCallback(callable $callback = null): static
+    public function setAutocompleterCallback(?callable $callback): static
     {
-        if (1 > \func_num_args()) {
-            trigger_deprecation('symfony/console', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);
-        }
         if ($this->hidden && null !== $callback) {
             throw new LogicException('A hidden question cannot use the autocompleter.');
         }
@@ -194,11 +191,8 @@ public function setAutocompleterCallback(callable $callback = null): static
      *
      * @return $this
      */
-    public function setValidator(callable $validator = null): static
+    public function setValidator(?callable $validator): static
     {
-        if (1 > \func_num_args()) {
-            trigger_deprecation('symfony/console', '6.2', 'Calling "%s()" without any arguments is deprecated, pass null explicitly instead.', __METHOD__);
-        }
         $this->validator = null === $validator ? null : $validator(...);
 
         return $this;