[Mime] Cache finfo objects to reduce open file handles and optimize perf

nicolas-grekas · nicolas-grekas · commit 6c7b0262eaf1 · 2024-09-11T12:33:59.000+02:00
diff --git a/src/Symfony/Component/Mime/FileinfoMimeTypeGuesser.php b/src/Symfony/Component/Mime/FileinfoMimeTypeGuesser.php
@@ -21,6 +21,8 @@
  */
 class FileinfoMimeTypeGuesser implements MimeTypeGuesserInterface
 {
+    private static $finfoCache = [];
+
     /**
      * @param string|null $magicFile A magic file to use with the finfo instance
      *
@@ -46,7 +48,7 @@ public function guessMimeType(string $path): ?string
             throw new LogicException(\sprintf('The "%s" guesser is not supported.', __CLASS__));
         }
 
-        if (false === $finfo = new \finfo(\FILEINFO_MIME_TYPE, $this->magicFile)) {
+        if (false === $finfo = self::$finfoCache[$this->magicFile] ??= new \finfo(\FILEINFO_MIME_TYPE, $this->magicFile)) {
             return null;
         }
         $mimeType = $finfo->file($path);

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,8 @@`
`21`	`21`	`*/`
`22`	`22`	`class FileinfoMimeTypeGuesser implements MimeTypeGuesserInterface`
`23`	`23`	`{`
	`24`	`+ private static $finfoCache = [];`
	`25`	`+`
`24`	`26`	`/**`
`25`	`27`	`* @param string\|null $magicFile A magic file to use with the finfo instance`
`26`	`28`	`*`
`@@ -46,7 +48,7 @@ public function guessMimeType(string $path): ?string`
`46`	`48`	`throw new LogicException(\sprintf('The "%s" guesser is not supported.', __CLASS__));`
`47`	`49`	`}`
`48`	`50`
`49`		`- if (false === $finfo = new \finfo(\FILEINFO_MIME_TYPE, $this->magicFile)) {`
	`51`	`+ if (false === $finfo = self::$finfoCache[$this->magicFile] ??= new \finfo(\FILEINFO_MIME_TYPE, $this->magicFile)) {`
`50`	`52`	`return null;`
`51`	`53`	`}`
`52`	`54`	`$mimeType = $finfo->file($path);`