PR 36579 fabbot patch after rebase

vjandrea · vjandrea · commit 6c67ce194583 · 2020-05-03T19:56:31.000+02:00
diff --git a/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php b/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
@@ -1086,7 +1086,7 @@ private function addNewInstance(Definition $definition, string $return = '', str
                 // If the class is a string we can optimize away
                 if (0 === strpos($class, "'") && false === strpos($class, '$')) {
                     if ("''" === $class) {
-                        throw new RuntimeException(sprintf('Cannot dump definition: %s service is defined to be created by a factory but is missing the service reference, did you forget to define the factory service id or class?', $id ? 'The "'.$id.'"' : 'inline'));
+                        throw new RuntimeException(sprintf('Cannot dump definition: "%s" service is defined to be created by a factory but is missing the service reference, did you forget to define the factory service id or class?', $id ? 'The "'.$id.'"' : 'inline'));
                     }
 
                     return $return.sprintf('%s::%s(%s)', $this->dumpLiteralClass($class), $callable[1], $arguments ? implode(', ', $arguments) : '').$tail;

Original file line number	Diff line number	Diff line change
`@@ -1086,7 +1086,7 @@ private function addNewInstance(Definition $definition, string $return = '', str`
`1086`	`1086`	`// If the class is a string we can optimize away`
`1087`	`1087`	`if (0 === strpos($class, "'") && false === strpos($class, '$')) {`
`1088`	`1088`	`if ("''" === $class) {`
`1089`		`- throw new RuntimeException(sprintf('Cannot dump definition: %s service is defined to be created by a factory but is missing the service reference, did you forget to define the factory service id or class?', $id ? 'The "'.$id.'"' : 'inline'));`
	`1089`	`+ throw new RuntimeException(sprintf('Cannot dump definition: "%s" service is defined to be created by a factory but is missing the service reference, did you forget to define the factory service id or class?', $id ? 'The "'.$id.'"' : 'inline'));`
`1090`	`1090`	`}`
`1091`	`1091`
`1092`	`1092`	`return $return.sprintf('%s::%s(%s)', $this->dumpLiteralClass($class), $callable[1], $arguments ? implode(', ', $arguments) : '').$tail;`