bug #36518 [Security] Fix missing nullable in CsrfTokenBadge (sstok)

chalasr · chalasr · commit 6b682bfcc5ea · 2020-04-21T18:49:50.000+02:00
This PR was merged into the 5.1-dev branch. Discussion ---------- [Security] Fix missing nullable in CsrfTokenBadge | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Related to #33558 I noticed a minor 🤏 bug with the method return-type. Commits ------- 5cb633c Update CsrfTokenBadge.php
diff --git a/src/Symfony/Component/Security/Http/Authenticator/Passport/Badge/CsrfTokenBadge.php b/src/Symfony/Component/Security/Http/Authenticator/Passport/Badge/CsrfTokenBadge.php
@@ -45,7 +45,7 @@ public function getCsrfTokenId(): string
         return $this->csrfTokenId;
     }
 
-    public function getCsrfToken(): string
+    public function getCsrfToken(): ?string
     {
         return $this->csrfToken;
     }

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public function getCsrfTokenId(): string`
`45`	`45`	`return $this->csrfTokenId;`
`46`	`46`	`}`
`47`	`47`
`48`		`- public function getCsrfToken(): string`
	`48`	`+ public function getCsrfToken(): ?string`
`49`	`49`	`{`
`50`	`50`	`return $this->csrfToken;`
`51`	`51`	`}`