[Config] Do not use absolute path when computing the vendor freshness

lyrixx · lyrixx · commit 6b30fc0f79d0 · 2019-07-17T16:39:35.000+02:00
When one uses Docker with a different mounting point between CLI &amp; FPM,
the cache keeps regenerating because the ComposerResource class see a
different path for each SAPI. For example `/home/app/app/vendor` vs `/var/www/app/vendor`.
So if you hit FPM, then the CLI, then FPM, each time a new cache is
generated. So the application is quite slow in dev env. And for people
on MacOSX (with docker) is a big pain! And obvisouly, this never
stabilizes !

This occurs a lot when you have a worker, that crash and reboot in the
background, and you browse the web interface. Or when you have something
that hit your API every X secondes, and you are working on a worker.
diff --git a/src/Symfony/Component/Config/Resource/ComposerResource.php b/src/Symfony/Component/Config/Resource/ComposerResource.php
@@ -71,12 +71,14 @@ private static function refresh()
     {
         self::$runtimeVendors = [];
 
+        $i = 0;
         foreach (get_declared_classes() as $class) {
             if ('C' === $class[0] && 0 === strpos($class, 'ComposerAutoloaderInit')) {
                 $r = new \ReflectionClass($class);
                 $v = \dirname(\dirname($r->getFileName()));
                 if (file_exists($v.'/composer/installed.json')) {
-                    self::$runtimeVendors[$v] = @filemtime($v.'/composer/installed.json');
+                    self::$runtimeVendors["__vendor_$i"] = @filemtime($v.'/composer/installed.json');
+                    ++$i;
                 }
             }
         }
diff --git a/src/Symfony/Component/Config/Tests/Resource/ComposerResourceTest.php b/src/Symfony/Component/Config/Tests/Resource/ComposerResourceTest.php
@@ -21,11 +21,10 @@ public function testGetVendor()
     {
         $res = new ComposerResource();
 
-        $r = new \ReflectionClass(ClassLoader::class);
         $found = false;
 
         foreach ($res->getVendors() as $vendor) {
-            if ($vendor && 0 === strpos($r->getFileName(), $vendor)) {
+            if ($vendor && 0 === strpos('__vendor_0', $vendor)) {
                 $found = true;
                 break;
             }

Original file line number	Diff line number	Diff line change
`@@ -71,12 +71,14 @@ private static function refresh()`
`71`	`71`	`{`
`72`	`72`	`self::$runtimeVendors = [];`
`73`	`73`
	`74`	`+ $i = 0;`
`74`	`75`	`foreach (get_declared_classes() as $class) {`
`75`	`76`	`if ('C' === $class[0] && 0 === strpos($class, 'ComposerAutoloaderInit')) {`
`76`	`77`	`$r = new \ReflectionClass($class);`
`77`	`78`	`$v = \dirname(\dirname($r->getFileName()));`
`78`	`79`	`if (file_exists($v.'/composer/installed.json')) {`
`79`		`- self::$runtimeVendors[$v] = @filemtime($v.'/composer/installed.json');`
	`80`	`+ self::$runtimeVendors["__vendor_$i"] = @filemtime($v.'/composer/installed.json');`
	`81`	`+ ++$i;`
`80`	`82`	`}`
`81`	`83`	`}`
`82`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,11 +21,10 @@ public function testGetVendor()`
`21`	`21`	`{`
`22`	`22`	`$res = new ComposerResource();`
`23`	`23`
`24`		`- $r = new \ReflectionClass(ClassLoader::class);`
`25`	`24`	`$found = false;`
`26`	`25`
`27`	`26`	`foreach ($res->getVendors() as $vendor) {`
`28`		`- if ($vendor && 0 === strpos($r->getFileName(), $vendor)) {`
	`27`	`+ if ($vendor && 0 === strpos('__vendor_0', $vendor)) {`
`29`	`28`	`$found = true;`
`30`	`29`	`break;`
`31`	`30`	`}`