minor #59775 [Notifier] do not implement JsonSerializable in MatrixOptions (xabbuh)

fabpot · fabpot · commit 6a6ebac3ad4e · 2025-02-14T14:12:23.000+01:00
This PR was merged into the 7.3 branch. Discussion ---------- [Notifier] do not implement JsonSerializable in MatrixOptions | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #59377 (comment) | License | MIT Commits ------- 1af047d do not implement JsonSerializable in MatrixOptions
diff --git a/src/Symfony/Component/Notifier/Bridge/Matrix/MatrixOptions.php b/src/Symfony/Component/Notifier/Bridge/Matrix/MatrixOptions.php
@@ -16,7 +16,7 @@
 /**
  * @author Frank Schulze <frank@akiber.de>
  */
-final class MatrixOptions implements MessageOptionsInterface, \JsonSerializable
+final class MatrixOptions implements MessageOptionsInterface
 {
     public function __construct(
         private array $options = [],
@@ -32,9 +32,4 @@ public function getRecipientId(): ?string
     {
         return $this->options['recipient_id'] ?? null;
     }
-
-    public function jsonSerialize(): mixed
-    {
-        return $this->options;
-    }
 }
diff --git a/src/Symfony/Component/Notifier/Bridge/Matrix/Tests/MatrixOptionsTest.php b/src/Symfony/Component/Notifier/Bridge/Matrix/Tests/MatrixOptionsTest.php
@@ -33,14 +33,4 @@ public function testGetRecipientId()
         ]);
         $this->assertSame('@testuser:matrix.io', $options->getRecipientId());
     }
-
-    public function testJsonSerialize()
-    {
-        $options = new MatrixOptions([
-            'recipient_id' => '@testuser:matrix.io',
-            'msgtype' => 'm.text',
-            'format' => 'org.matrix.custom.html',
-        ]);
-        $this->assertSame(['recipient_id' => '@testuser:matrix.io', 'msgtype' => 'm.text', 'format' => 'org.matrix.custom.html'], $options->jsonSerialize());
-    }
 }

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`/**`
`17`	`17`	`* @author Frank Schulze <frank@akiber.de>`
`18`	`18`	`*/`
`19`		`-final class MatrixOptions implements MessageOptionsInterface, \JsonSerializable`
	`19`	`+final class MatrixOptions implements MessageOptionsInterface`
`20`	`20`	`{`
`21`	`21`	`public function __construct(`
`22`	`22`	`private array $options = [],`
`@@ -32,9 +32,4 @@ public function getRecipientId(): ?string`
`32`	`32`	`{`
`33`	`33`	`return $this->options['recipient_id'] ?? null;`
`34`	`34`	`}`
`35`		`-`
`36`		`- public function jsonSerialize(): mixed`
`37`		`- {`
`38`		`- return $this->options;`
`39`		`- }`
`40`	`35`	`}`