8000 feature #114 Drop support for Symfony 4 (derrabus) · symfony/symfony@694016e · GitHub
[go: up one dir, main page]
Skip to content

Commit 694016e

Browse files
derrabusderrabus
committed
feature #114 Drop support for Symfony 4 (derrabus)
This PR was merged into the 2.1-dev branch. Discussion ---------- Drop support for Symfony 4 Symfony 4 is dead and dropping support for it should make the maintenance of this package a bit easier. Commits ------- b360b35 Drop support for Symfony 4
2 parents 998d8d2 + b360b35 commit 694016e

8000 File tree

6 files changed

+17
-82
lines changed

6 files changed

+17
-82
lines changed

‎.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
strategy:
1313
fail-fast: false
1414
matrix:
15-
php: ['7.1.3', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2']
15+
php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2']
1616
include:
1717
- php: '7.4'
1818
deps: lowest

‎CHANGELOG.md

Lines changed: 5 additions & 0 deletions
    • < 8000 li class="Box-sc-g0xbh4-0 jBWIdY prc-SegmentedControl-Item-7Aq6h">
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
CHANGELOG
22
=========
33

4+
# 2.2.0 (TBA)
5+
6+
* Drop support for Symfony 4
7+
* Bump minimum version of PHP to 7.2
8+
49
# 2.1.3 (2022-09-05)
510

611
* Ignore invalid HTTP headers when creating PSR7 objects

‎Tests/EventListener/PsrResponseListenerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,6 @@ public function testDoesNotConvertControllerResult()
4848

4949
private function createEventMock($controllerResult): ViewEvent
5050
{
51-
return new ViewEvent($this->createMock(HttpKernelInterface::class), new Request(), HttpKernelInterface::MASTER_REQUEST, $controllerResult);
51+
return new ViewEvent($this->createMock(HttpKernelInterface::class), new Request(), HttpKernelInterface::MAIN_REQUEST, $controllerResult);
5252
}
5353
}

‎Tests/Fixtures/App/Kernel44.php

Lines changed: 0 additions & 68 deletions
This file was deleted.

‎Tests/Functional/ControllerTest.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@
1212
namespace Symfony\Bridge\PsrHttpMessage\Tests\Functional;
1313

1414
use Symfony\Bridge\PsrHttpMessage\Tests\Fixtures\App\Kernel;
15-
use Symfony\Bridge\PsrHttpMessage\Tests\Fixtures\App\Kernel44;
1615
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
17-
use Symfony\Component\HttpKernel\Kernel as SymfonyKernel;
1816

1917
/**
2018
* @author Alexander M. Turek <me@derrabus.de>
@@ -50,6 +48,6 @@ public function testMessageAction()
5048

5149
protected static function getKernelClass(): string
5250
{
53-
return SymfonyKernel::VERSION_ID >= 50200 ? Kernel::class : Kernel44::class;
51+
return Kernel::class;
5452
}
5553
}

‎composer.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,17 @@
1616
}
1717
],
1818
"require": {
19-
"php": ">=7.1",
19+
"php": ">=7.2.5",
2020
"psr/http-message": "^1.0",
21-
"symfony/http-foundation": "^4.4 || ^5.0 || ^6.0"
21+
"symfony/http-foundation": "^5.4 || ^6.0"
2222
},
2323
"require-dev": {
24-
"symfony/browser-kit": "^4.4 || ^5.0 || ^6.0",
25-
"symfony/config": "^4.4 || ^5.0 || ^6.0",
26-
"symfony/event-dispatcher": "^4.4 || ^5.0 || ^6.0",
27-
"symfony/framework-bundle": "^4.4 || ^5.0 || ^6.0",
28-
"symfony/http-kernel": "^4.4 || ^5.0 || ^6.0",
29-
"symfony/phpunit-bridge": "^5.4@dev || ^6.0",
24+
"symfony/browser-kit": "^5.4 || ^6.0",
25+
"symfony/config": "^5.4 || ^6.0",
26+
"symfony/event-dispatcher": "^5.4 || ^6.0",
27+
"symfony/framework-bundle": "^5.4 || ^6.0",
28+
"symfony/http-kernel": "^5.4 || ^6.0",
29+
"symfony/phpunit-bridge": "^6.2",
3030
"nyholm/psr7": "^1.1",
3131
"psr/log": "^1.1 || ^2 || ^3"
3232
},
@@ -41,7 +41,7 @@
4141
},
4242
"extra": {
4343
"branch-alias": {
44-
"dev-main": "2.1-dev"
44+
"dev-main": "2.2-dev"
4545
}
4646
}
4747
}

0 commit comments

Comments
 (0)
0