symfony
diff --git a/‎UPGRADE-3.2.md‎
Lines changed: 5 additions & 0 deletions b/‎UPGRADE-3.2.md‎
Lines changed: 5 additions & 0 deletions
diff --git a/‎UPGRADE-4.0.md‎
Lines changed: 3 additions & 0 deletions b/‎UPGRADE-4.0.md‎
Lines changed: 3 additions & 0 deletions
diff --git a/‎src/Symfony/Component/HttpKernel/DataCollector/RequestDataCollector.php‎
Lines changed: 1 addition & 42 deletions b/‎src/Symfony/Component/HttpKernel/DataCollector/RequestDataCollector.php‎
Lines changed: 1 addition & 42 deletions
@@ -94,6 +94,11 @@ HttpFoundation
      - `isInvalid`/`isSuccessful`/`isRedirection`/`isClientError`/`isServerError`
      - `isOk`/`isForbidden`/`isNotFound`/`isRedirect`/`isEmpty`
 
+  * Checking only for cacheable HTTP methods with `Request::isMethodSafe()` is deprecated 
+    since version 3.2 and will throw an exception in 4.0. Disable checking only for 
+    cacheable methods by calling the method with `false` as first argument or use 
+    `Request::isMethodCacheable()` instead.
+
 HttpKernel
 ----------
 
 
@@ -173,6 +173,9 @@ HttpFoundation
     - `isInvalid`/`isSuccessful`/`isRedirection`/`isClientError`/`isServerError`
     - `isOk`/`isForbidden`/`isNotFound`/`isRedirect`/`isEmpty`
 
+ * The ability to check only for cacheable HTTP methods using `Request::isMethodSafe()` is
+   not supported anymore, use `Request::isMethodCacheable()` instead.
+
 HttpKernel
 ----------
 
 
@@ -40,12 +40,8 @@ public function __construct()
     public function collect(Request $request, Response $response, \Exception $exception = null)
     {
         $responseHeaders = $response->headers->all();
-        $cookies = array();
         foreach ($response->headers->getCookies() as $cookie) {
-            $cookies[] = $this->getCookieHeader($cookie->getName(), $cookie->getValue(), $cookie->getExpiresTime(), $cookie->getPath(), $cookie->getDomain(), $cookie->isSecure(), $cookie->isHttpOnly());
-        }
-        if (count($cookies) > 0) {
-            $responseHeaders['Set-Cookie'] = $cookies;
+            $responseHeaders['set-cookie'][] = (string) $cookie;
         }
 
         // attributes are serialized and as they can be anything, they need to be converted to strings.
@@ -403,41 +399,4 @@ protected function parseController($controller)
 
         return is_string($controller) ? $controller : 'n/a';
     }
-
-    private function getCookieHeader($name, $value, $expires, $path, $domain, $secure, $httponly)
-    {
-        $cookie = sprintf('%s=%s', $name, urlencode($value));
-
-        if (0 !== $expires) {
-            if (is_numeric($expires)) {
-                $expires = (int) $expires;
-            } elseif ($expires instanceof \DateTime) {
-                $expires = $expires->getTimestamp();
-            } else {
-                $tmp = strtotime($expires);
-                if (false === $tmp || -1 == $tmp) {
-                    throw new \InvalidArgumentException(sprintf('The "expires" cookie parameter is not valid (%s).', $expires));
-                }
-                $expires = $tmp;
-            }
-
-            $cookie .= '; expires='.str_replace('+0000', '', \DateTime::createFromFormat('U', $expires, new \DateTimeZone('GMT'))->format('D, d-M-Y H:i:s T'));
-        }
-
-        if ($domain) {
-            $cookie .= '; domain='.$domain;
-        }
-
-        $cookie .= '; path='.$path;
-
-        if ($secure) {
-            $cookie .= '; secure';
-        }
-
-        if ($httponly) {
-            $cookie .= '; httponly';
-        }
-
-        return $cookie;
-    }
 }