[DX] [DI] Improve exception for invalid setter injection arguments

curry684 · curry684 · commit 6850a228a719 · 2018-01-03T12:24:16.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php
@@ -476,6 +476,9 @@ private function parseDefinition($id, $service, $file, array $defaults)
                     $args = isset($call[1]) ? $this->resolveServices($call[1], $file) : array();
                 }
 
+                if (!is_array($args)) {
+                    throw new InvalidArgumentException(sprintf('The second parameter for function call "%s" must be an array of its arguments for service "%s" in %s. Check your YAML syntax.', $method, $id, $file));
+                }
                 $definition->addMethodCall($method, $args);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -476,6 +476,9 @@ private function parseDefinition($id, $service, $file, array $defaults)`
`476`	`476`	`$args = isset($call[1]) ? $this->resolveServices($call[1], $file) : array();`
`477`	`477`	`}`
`478`	`478`
	`479`	`+ if (!is_array($args)) {`
	`480`	`+ throw new InvalidArgumentException(sprintf('The second parameter for function call "%s" must be an array of its arguments for service "%s" in %s. Check your YAML syntax.', $method, $id, $file));`
	`481`	`+ }`
`479`	`482`	`$definition->addMethodCall($method, $args);`
`480`	`483`	`}`
`481`	`484`	`}`