minor #26676 [Messenger] Uses the messenger.message_handler tag instead of message.handler (sroze)

fabpot · fabpot · commit 6806f664f34d · 2018-03-27T09:12:41.000+02:00
This PR was merged into the 4.1-dev branch. Discussion ---------- [Messenger] Uses the `messenger.message_handler` tag instead of `message.handler` | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no (technically, it's not even in 4.1) | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT After a few days using it, it feels weird to have the `messenger.receiver` and `messenger.sender` tags while the one for message handlers is `message_handler`. I believe that for consistency, this would make sense to rename this tag `messenger.message_handler`. As we don't have tests for this pass yet (will be added in #26672) there is nothing else to change (but the documentation). Commits ------- bddebc4 Uses the `messenger.message_handler` tag instead of `message.handler`
diff --git a/src/Symfony/Component/Messenger/DependencyInjection/MessengerPass.php b/src/Symfony/Component/Messenger/DependencyInjection/MessengerPass.php
@@ -31,7 +31,7 @@ class MessengerPass implements CompilerPassInterface
     private $messageHandlerResolverService;
     private $handlerTag;
 
-    public function __construct(string $messageBusService = 'message_bus', string $messageHandlerResolverService = 'messenger.handler_resolver', string $handlerTag = 'message_handler')
+    public function __construct(string $messageBusService = 'message_bus', string $messageHandlerResolverService = 'messenger.handler_resolver', string $handlerTag = 'messenger.message_handler')
     {
         $this->messageBusService = $messageBusService;
         $this->messageHandlerResolverService = $messageHandlerResolverService;

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ class MessengerPass implements CompilerPassInterface`
`31`	`31`	`private $messageHandlerResolverService;`
`32`	`32`	`private $handlerTag;`
`33`	`33`
`34`		`- public function __construct(string $messageBusService = 'message_bus', string $messageHandlerResolverService = 'messenger.handler_resolver', string $handlerTag = 'message_handler')`
	`34`	`+ public function __construct(string $messageBusService = 'message_bus', string $messageHandlerResolverService = 'messenger.handler_resolver', string $handlerTag = 'messenger.message_handler')`
`35`	`35`	`{`
`36`	`36`	`$this->messageBusService = $messageBusService;`
`37`	`37`	`$this->messageHandlerResolverService = $messageHandlerResolverService;`