Fix order array sum normalizedData and nestedData

jerowork · jerowork · commit 67f49d4c940b · 2023-10-03T10:16:00.000+02:00
Previously, when `array_merge` was changed array+array in 6.3.5, the combined
array result is changed as well. array_merge behaves differently than array+array.

e.g.:
```
$a = ['key' =&gt; 'value-a'];
$b = ['key' =&gt; 'value-b'];

var_dump(array_merge($a, $b));
// Results in:
// array(1) {
//   ["key"]=&gt;
//   string(7) "value-b"
// }

var_dump($a + $b);
// Results in:
// array(1) {
//   ["key"]=&gt;
//   string(7) "value-a"
// }
```

By switching left with right, the result will be the same again.
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
@@ -339,7 +339,7 @@ public function denormalize(mixed $data, string $type, string $format = null, ar
             $normalizedData = $this->removeNestedValue($serializedPath->getElements(), $normalizedData);
         }
 
-        $normalizedData = $normalizedData + $nestedData;
+        $normalizedData = $nestedData + $normalizedData;
 
         $object = $this->instantiateObject($normalizedData, $mappedClass, $context, new \ReflectionClass($mappedClass), $allowedAttributes, $format);
         $resolvedClass = ($this->objectClassResolver)($object);
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php
@@ -813,6 +813,28 @@ public function testDenormalizeWithNumberAsSerializedNameAndNoArrayReindex()
         $this->assertSame('foo', $test->foo);
         $this->assertSame('baz', $test->baz);
     }
+
+    public function testDenormalizeWithCorrectOrderOfAttributeAndProperty()
+    {
+        $normalizer = new AbstractObjectNormalizerWithMetadata();
+
+        $data = [
+            'id' => 'root-level-id',
+            'data' => [
+                'id' => 'nested-id',
+            ],
+        ];
+
+        $obj = new class() {
+            /**
+             * @SerializedPath("[data][id]")
+             */
+            public $id;
+        };
+
+        $test = $normalizer->denormalize($data, $obj::class);
+        $this->assertSame('nested-id', $test->id);
+    }
 }
 
 class AbstractObjectNormalizerDummy extends AbstractObjectNormalizer

Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,7 @@ public function denormalize(mixed $data, string $type, string $format = null, ar`
`339`	`339`	`$normalizedData = $this->removeNestedValue($serializedPath->getElements(), $normalizedData);`
`340`	`340`	`}`
`341`	`341`
`342`		`- $normalizedData = $normalizedData + $nestedData;`
	`342`	`+ $normalizedData = $nestedData + $normalizedData;`
`343`	`343`
`344`	`344`	`$object = $this->instantiateObject($normalizedData, $mappedClass, $context, new \ReflectionClass($mappedClass), $allowedAttributes, $format);`
`345`	`345`	`$resolvedClass = ($this->objectClassResolver)($object);`