bug #39350 [FrameworkBundle] Remove translation data_collector BEFORE adding it to profiler (l-vo)

fabpot · fabpot · commit 66e8ae934b4d · 2021-09-21T15:39:22.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Remove translation data_collector BEFORE adding it to profiler | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | There is an order problem between `DataCollectorTranslatorPass` and `ProfilerPass`. Currently `DataCollectorTranslatorPass` is registered after `ProfilerPass`. So if `data_collector.translation` is removed, it has already been added to the profiler and the compilation fails. The simplest approach seems to move `DataCollectorTranslatorPass` before `ProfilerPass`. Use case: When I want to use `IdentityTranslator` (for the test environment for instance) which doesn't implement `TranslatorBagInterface`. Commits ------- 2420b67 [FrameworkBundle] Remove translation data_collector BEFORE adding it to profiler
diff --git a/src/Symfony/Bundle/FrameworkBundle/FrameworkBundle.php b/src/Symfony/Bundle/FrameworkBundle/FrameworkBundle.php
@@ -119,6 +119,7 @@ public function build(ContainerBuilder $container)
         $container->addCompilerPass(new RegisterControllerArgumentLocatorsPass());
         $container->addCompilerPass(new RemoveEmptyControllerArgumentLocatorsPass(), PassConfig::TYPE_BEFORE_REMOVING);
         $container->addCompilerPass(new RoutingResolverPass());
+        $container->addCompilerPass(new DataCollectorTranslatorPass());
         $container->addCompilerPass(new ProfilerPass());
         // must be registered before removing private services as some might be listeners/subscribers
         // but as late as possible to get resolved parameters
@@ -139,7 +140,6 @@ public function build(ContainerBuilder $container)
         $container->addCompilerPass(new FragmentRendererPass());
         $this->addCompilerPassIfExists($container, SerializerPass::class);
         $this->addCompilerPassIfExists($container, PropertyInfoPass::class);
-        $container->addCompilerPass(new DataCollectorTranslatorPass());
         $container->addCompilerPass(new ControllerArgumentValueResolverPass());
         $container->addCompilerPass(new CachePoolPass(), PassConfig::TYPE_BEFORE_OPTIMIZATION, 32);
         $container->addCompilerPass(new CachePoolClearerPass(), PassConfig::TYPE_AFTER_REMOVING);
