[HttpFoundation][Session] memcached connection should not be closed

klandaika · klandaika · commit 66d7dccb7724 · 2016-11-01T13:31:37.000-04:00
diff --git a/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/MemcacheSessionHandler.php b/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/MemcacheSessionHandler.php
@@ -71,7 +71,7 @@ public function open($savePath, $sessionName)
      */
     public function close()
     {
-        return $this->memcache->close();
+        return true;
     }
 
     /**
diff --git a/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcacheSessionHandlerTest.php b/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcacheSessionHandlerTest.php
@@ -50,12 +50,6 @@ public function testOpenSession()
 
     public function testCloseSession()
     {
-        $this->memcache
-            ->expects($this->once())
-            ->method('close')
-            ->will($this->returnValue(true))
-        ;
-
         $this->assertTrue($this->storage->close());
     }
 

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ public function open($savePath, $sessionName)`
`71`	`71`	`*/`
`72`	`72`	`public function close()`
`73`	`73`	`{`
`74`		`- return $this->memcache->close();`
	`74`	`+ return true;`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -50,12 +50,6 @@ public function testOpenSession()`
`50`	`50`
`51`	`51`	`public function testCloseSession()`
`52`	`52`	`{`
`53`		`- $this->memcache`
`54`		`- ->expects($this->once())`
`55`		`- ->method('close')`
`56`		`- ->will($this->returnValue(true))`
`57`		`- ;`
`58`		`-`
`59`	`53`	`$this->assertTrue($this->storage->close());`
`60`	`54`	`}`
`61`	`55`