Revert "bug #25487 [Console] Fix a bug when passing a letter that could be an alias (Simperfit)"

fabpot · fabpot · commit 667b9295f86d · 2018-01-26T16:23:25.000+01:00
This reverts commit ccc9367, reversing changes made to e77545a.
diff --git a/src/Symfony/Component/Console/Input/ArgvInput.php b/src/Symfony/Component/Console/Input/ArgvInput.php
@@ -284,8 +284,6 @@ public function hasParameterOption($values)
                 }
 
                 if (0 === strpos($token, '-') && 0 !== strpos($token, '--')) {
-                    $noValue = explode('=', $token);
-                    $token = $noValue[0];
                     $searchableToken = str_replace('-', '', $token);
                     $searchableValue = str_replace('-', '', $value);
                     if ('' !== $searchableToken && '' !== $searchableValue && false !== strpos($searchableToken, $searchableValue)) {
diff --git a/src/Symfony/Component/Console/Tests/Input/ArgvInputTest.php b/src/Symfony/Component/Console/Tests/Input/ArgvInputTest.php
@@ -299,9 +299,6 @@ public function testHasParameterOption()
         $input = new ArgvInput(array('cli.php', '-fh'));
         $this->assertTrue($input->hasParameterOption('-fh'), '->hasParameterOption() returns true if the given short option is in the raw input');
 
-        $input = new ArgvInput(array('cli.php', '-e=test'));
-        $this->assertFalse($input->hasParameterOption('-s'), '->hasParameterOption() returns true if the given short option is in the raw input');
-
         $input = new ArgvInput(array('cli.php', '--foo', 'foo'));
         $this->assertTrue($input->hasParameterOption('--foo'), '->hasParameterOption() returns true if the given short option is in the raw input');
 

Original file line number	Diff line number	Diff line change
`@@ -284,8 +284,6 @@ public function hasParameterOption($values)`
`284`	`284`	`}`
`285`	`285`
`286`	`286`	`if (0 === strpos($token, '-') && 0 !== strpos($token, '--')) {`
`287`		`- $noValue = explode('=', $token);`
`288`		`- $token = $noValue[0];`
`289`	`287`	`$searchableToken = str_replace('-', '', $token);`
`290`	`288`	`$searchableValue = str_replace('-', '', $value);`
`291`	`289`	`if ('' !== $searchableToken && '' !== $searchableValue && false !== strpos($searchableToken, $searchableValue)) {`