skip bcrypt tests on incompatible platforms

Christian Flothmann · Christian Flothmann · commit 65eb18849a42 · 2015-12-19T15:13:08.000+01:00
Not all PHP versions before 5.3.7 have backported fixes that make it
possible to use `password_hash()` function. Therefore, we have to skip
tests on not supported platforms.
diff --git a/src/Symfony/Component/Security/Tests/Core/Encoder/BCryptPasswordEncoderTest.php b/src/Symfony/Component/Security/Tests/Core/Encoder/BCryptPasswordEncoderTest.php
@@ -47,13 +47,17 @@ public function testCostInRange()
 
     public function testResultLength()
     {
+        $this->skipIfPhpVersionIsNotSupported();
+
         $encoder = new BCryptPasswordEncoder(self::VALID_COST);
         $result = $encoder->encodePassword(self::PASSWORD, null);
         $this->assertEquals(60, strlen($result));
     }
 
     public function testValidation()
     {
+        $this->skipIfPhpVersionIsNotSupported();
+
         $encoder = new BCryptPasswordEncoder(self::VALID_COST);
         $result = $encoder->encodePassword(self::PASSWORD, null);
         $this->assertTrue($encoder->isPasswordValid($result, self::PASSWORD, null));
@@ -72,10 +76,19 @@ public function testEncodePasswordLength()
 
     public function testCheckPasswordLength()
     {
+        $this->skipIfPhpVersionIsNotSupported();
+
         $encoder = new BCryptPasswordEncoder(self::VALID_COST);
         $result = $encoder->encodePassword(str_repeat('a', 72), null);
 
         $this->assertFalse($encoder->isPasswordValid($result, str_repeat('a', 73), 'salt'));
         $this->assertTrue($encoder->isPasswordValid($result, str_repeat('a', 72), 'salt'));
     }
+
+    private function skipIfPhpVersionIsNotSupported()
+    {
+        if (PHP_VERSION_ID < 50307 && !\PasswordCompat\binary\check()) {
+            $this->markTestSkipped('Skipping test as this PHP version is not compatible with the ircmaxell/password-compat library.');
+        }
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -47,13 +47,17 @@ public function testCostInRange()`
`47`	`47`
`48`	`48`	`public function testResultLength()`
`49`	`49`	`{`
	`50`	`+ $this->skipIfPhpVersionIsNotSupported();`
	`51`	`+`
`50`	`52`	`$encoder = new BCryptPasswordEncoder(self::VALID_COST);`
`51`	`53`	`$result = $encoder->encodePassword(self::PASSWORD, null);`
`52`	`54`	`$this->assertEquals(60, strlen($result));`
`53`	`55`	`}`
`54`	`56`
`55`	`57`	`public function testValidation()`
`56`	`58`	`{`
	`59`	`+ $this->skipIfPhpVersionIsNotSupported();`
	`60`	`+`
`57`	`61`	`$encoder = new BCryptPasswordEncoder(self::VALID_COST);`
`58`	`62`	`$result = $encoder->encodePassword(self::PASSWORD, null);`
`59`	`63`	`$this->assertTrue($encoder->isPasswordValid($result, self::PASSWORD, null));`
`@@ -72,10 +76,19 @@ public function testEncodePasswordLength()`
`72`	`76`
`73`	`77`	`public function testCheckPasswordLength()`
`74`	`78`	`{`
	`79`	`+ $this->skipIfPhpVersionIsNotSupported();`
	`80`	`+`
`75`	`81`	`$encoder = new BCryptPasswordEncoder(self::VALID_COST);`
`76`	`82`	`$result = $encoder->encodePassword(str_repeat('a', 72), null);`
`77`	`83`
`78`	`84`	`$this->assertFalse($encoder->isPasswordValid($result, str_repeat('a', 73), 'salt'));`
`79`	`85`	`$this->assertTrue($encoder->isPasswordValid($result, str_repeat('a', 72), 'salt'));`
`80`	`86`	`}`
	`87`	`+`
	`88`	`+ private function skipIfPhpVersionIsNotSupported()`
	`89`	`+ {`
	`90`	`+ if (PHP_VERSION_ID < 50307 && !\PasswordCompat\binary\check()) {`
	`91`	`+ $this->markTestSkipped('Skipping test as this PHP version is not compatible with the ircmaxell/password-compat library.');`
	`92`	`+ }`
	`93`	`+ }`
`81`	`94`	`}`