feature #30887 [FrameworkBundle] fix search in debug autowiring (sez-open)

nicolas-grekas · nicolas-grekas · commit 65b46a532c3f · 2019-04-07T09:30:18.000+02:00
This PR was merged into the 4.3-dev branch. Discussion ---------- [FrameworkBundle] fix search in debug autowiring | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | #30493  | License | MIT | Doc PR |  Taking #30522 and finishing it with @nicolas-grekas comments. Is the sentence ok ? Commits ------- fec4bea fix debug:autowiringcommand
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/DebugAutowiringCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/DebugAutowiringCommand.php
@@ -100,6 +100,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $hasAlias = [];
         $all = $input->getOption('all');
         $previousId = '-';
+        $serviceIdsNb = 0;
         foreach ($serviceIds as $serviceId) {
             $text = [];
             if (0 !== strpos($serviceId, $previousId)) {
@@ -127,11 +128,22 @@ protected function execute(InputInterface $input, OutputInterface $output)
                     $serviceLine .= ' - <fg=magenta>deprecated</>';
                 }
             } elseif (!$all) {
+                ++$serviceIdsNb;
                 continue;
             }
             $text[] = $serviceLine;
             $io->text($text);
         }
+
+        $io->newLine();
+
+        if (0 < $serviceIdsNb) {
+            $io->text(sprintf('%s more concrete service%s would be displayed when adding the "--all" option.', $serviceIdsNb, $serviceIdsNb > 1 ? 's' : ''));
+        }
+        if ($all) {
+            $io->text('Pro-tip: use interfaces in your type-hints instead of classes to benefit from the dependency inversion principle.');
+        }
+
         $io->newLine();
     }
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/DebugAutowiringCommandTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/DebugAutowiringCommandTest.php
@@ -72,4 +72,29 @@ public function testSearchNoResults()
         $this->assertContains('No autowirable classes or interfaces found matching "foo_fake"', $tester->getErrorOutput());
         $this->assertEquals(1, $tester->getStatusCode());
     }
+
+    public function testSearchNotAliasedService()
+    {
+        static::bootKernel(['test_case' => 'ContainerDebug', 'root_config' => 'config.yml']);
+
+        $application = new Application(static::$kernel);
+        $application->setAutoExit(false);
+
+        $tester = new ApplicationTester($application);
+        $tester->run(['command' => 'debug:autowiring', 'search' => 'redirect']);
+
+        $this->assertContains(' more concrete service would be displayed when adding the "--all" option.', $tester->getDisplay());
+    }
+
+    public function testSearchNotAliasedServiceWithAll()
+    {
+        static::bootKernel(['test_case' => 'ContainerDebug', 'root_config' => 'config.yml']);
+
+        $application = new Application(static::$kernel);
+        $application->setAutoExit(false);
+
+        $tester = new ApplicationTester($application);
+        $tester->run(['command' => 'debug:autowiring', 'search' => 'redirect', '--all' => true]);
+        $this->assertContains('Pro-tip: use interfaces in your type-hints instead of classes to benefit from the dependency inversion principle.', $tester->getDisplay());
+    }
 }
