8000 minor #38637 Enable Doctrine tests on php 8 (derrabus) · symfony/symfony@65b41de · GitHub
[go: up one dir, main page]
Skip to content

Commit 65b41de

Browse files
fabpotfabpot
committed
minor #38637 Enable Doctrine tests on php 8 (derrabus)
This PR was merged into the 4.4 branch. Discussion ---------- Enable Doctrine tests on php 8 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #36872 | License | MIT | Doc PR | N/A Continuation of #38636 on 4.4. Commits ------- c65c6ea Don't skip Doctrine tests on php 8.
2 parents e693b3c + c65c6ea commit 65b41de

File tree

4 files changed

+0
-23
lines changed

4 files changed

+0
-23
lines changed

‎src/Symfony/Component/Cache/Tests/Adapter/PdoAdapterTest.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
namespace Symfony\Component\Cache\Tests\Adapter;
1313

14-
use Doctrine\DBAL\Version;
1514
use Psr\Cache\CacheItemPoolInterface;
1615
use Symfony\Component\Cache\Adapter\PdoAdapter;
1716
use Symfony\Component\Cache\Tests\Traits\PdoPruneableTrait;
@@ -31,10 +30,6 @@ public static function setUpBeforeClass(): void
3130
self::markTestSkipped('Extension pdo_sqlite required.');
3231
}
3332

34-
if (\PHP_VERSION_ID >= 80000 && class_exists(Version::class)) {
35-
self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
36-
}
37-
3833
self::$dbFile = tempnam(sys_get_temp_dir(), 'sf_sqlite_cache');
3934

4035
$pool = new PdoAdapter('sqlite:'.self::$dbFile);

‎src/Symfony/Component/Lock/Tests/Store/PdoDbalStoreTest.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
namespace Symfony\Component\Lock\Tests\Store;
1313

1414
use Doctrine\DBAL\DriverManager;
15-
use Doctrine\DBAL\Version;
1615
use Symfony\Component\Lock\PersistingStoreInterface;
1716
use Symfony\Component\Lock\Store\PdoStore;
1817

@@ -31,10 +30,6 @@ public static function setUpBeforeClass(): void
3130
{
3231
self::$dbFile = tempnam(sys_get_temp_dir(), 'sf_sqlite_lock');
3332

34-
if (\PHP_VERSION_ID >= 80000 && class_exists(Version::class)) {
35-
self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
36-
}
37-
3833
$store = new PdoStore(DriverManager::getConnection(['driver' => 'pdo_sqlite', 'path' => self::$dbFile]));
3934
$store->createTable();
4035
}

‎src/Symfony/Component/Lock/Tests/Store/PdoStoreTest.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
namespace Symfony\Component\Lock\Tests\Store;
1313

14-
use Doctrine\DBAL\Version;
1514
use Symfony\Component\Lock\Key;
1615
use Symfony\Component\Lock\PersistingStoreInterface;
1716
use Symfony\Component\Lock\Store\PdoStore;
@@ -31,10 +30,6 @@ public static function setUpBeforeClass(): void
3130
{
3231
self::$dbFile = tempnam(sys_get_temp_dir(), 'sf_sqlite_lock');
3332

34-
if (\PHP_VERSION_ID >= 80000 && class_exists(Version::class)) {
35-
self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
36-
}
37-
3833
$store = new PdoStore('sqlite:'.self::$dbFile);
3934
$store->createTable();
4035
}

‎src/Symfony/Component/Messenger/Tests/Transport/Doctrine/DoctrineIntegrationTest.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
use Doctrine\DBAL\Driver\Result as DriverResult;
1515
use Doctrine\DBAL\DriverManager;
1616
use Doctrine\DBAL\Result;
17-
use Doctrine\DBAL\Version;
1817
use PHPUnit\Framework\TestCase;
1918
use Symfony\Component\Messenger\Tests\Fixtures\DummyMessage;
2019
use Symfony\Component\Messenger\Transport\Doctrine\Connection;
@@ -31,13 +30,6 @@ class DoctrineIntegrationTest extends TestCase
3130
/** @var string */
3231
private $sqliteFile;
3332

34-
public static function setUpBeforeClass(): void
35-
{
36-
if (\PHP_VERSION_ID >= 80000 && class_exists(Version::class)) {
37-
self::markTestSkipped('Doctrine DBAL 2.x is incompatible with PHP 8.');
38-
}
39-
}
40-
4133
protected function setUp(): void
4234
{
4335
$this->sqliteFile = sys_get_temp_dir().'/symfony.messenger.sqlite';

0 commit comments

Comments
 (0)
0