Improve unit test

BrokenSourceCode · BrokenSourceCode · commit 657f020a8290 · 2022-07-31T18:12:45.000+02:00
diff --git a/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Proxy/SessionHandlerProxyTest.php b/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Proxy/SessionHandlerProxyTest.php
@@ -163,12 +163,21 @@ public function testUpdateTimestamp()
     }
 
     /**
-     * https://github.com/symfony/symfony/pull/47130.
+     * @dataProvider provideNativeSessionStorageHandler
+     * @see https://github.com/symfony/symfony/pull/47130.
      */
-    public function testNativeSessionStorageSaveHandlerNameWithStrictSessionHandler()
+    public function testNativeSessionStorageSaveHandlerName($handler)
     {
-        $storage = new NativeSessionStorage([], new StrictSessionHandler(new \SessionHandler()));
-        $this->assertEquals('files', $storage->getSaveHandler()->getSaveHandlerName());
+        $this->assertEquals('files', (new NativeSessionStorage([], $handler))->getSaveHandler()->getSaveHandlerName());
+    }
+
+    public function provideNativeSessionStorageHandler()
+    {
+        return [
+            [new \SessionHandler()],
+            [new StrictSessionHandler(new \SessionHandler())],
+            [new SessionHandlerProxy(new StrictSessionHandler(new \SessionHandler()))]
+        ];
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -163,12 +163,21 @@ public function testUpdateTimestamp()`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`/**`
`166`		`- * https://github.com/symfony/symfony/pull/47130.`
	`166`	`+ * @dataProvider provideNativeSessionStorageHandler`
	`167`	`+ * @see https://github.com/symfony/symfony/pull/47130.`
`167`	`168`	`*/`
`168`		`- public function testNativeSessionStorageSaveHandlerNameWithStrictSessionHandler()`
	`169`	`+ public function testNativeSessionStorageSaveHandlerName($handler)`
`169`	`170`	`{`
`170`		`- $storage = new NativeSessionStorage([], new StrictSessionHandler(new \SessionHandler()));`
`171`		`- $this->assertEquals('files', $storage->getSaveHandler()->getSaveHandlerName());`
	`171`	`+ $this->assertEquals('files', (new NativeSessionStorage([], $handler))->getSaveHandler()->getSaveHandlerName());`
	`172`	`+ }`
	`173`	`+`
	`174`	`+ public function provideNativeSessionStorageHandler()`
	`175`	`+ {`
	`176`	`+ return [`
	`177`	`+ [new \SessionHandler()],`
	`178`	`+ [new StrictSessionHandler(new \SessionHandler())],`
	`179`	`+ [new SessionHandlerProxy(new StrictSessionHandler(new \SessionHandler()))]`
	`180`	`+ ];`
`172`	`181`	`}`
`173`	`182`	`}`
`174`	`183`