[DI] Don't show internal service id on binding errors

nicolas-grekas · nicolas-grekas · commit 62d431659d25 · 2018-07-03T21:42:53.000+02:00
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/ResolveInstanceofConditionalsPass.php b/src/Symfony/Component/DependencyInjection/Compiler/ResolveInstanceofConditionalsPass.php
@@ -117,9 +117,11 @@ private function processDefinition(ContainerBuilder $container, $id, Definition
                 }
             }
 
+            $definition->setBindings($bindings);
+
             // reset fields with "merge" behavior
             $abstract
-                ->setBindings($bindings)
+                ->setBindings(array())
                 ->setArguments(array())
                 ->setMethodCalls(array())
                 ->setDecoratedService(null)

Original file line number	Diff line number	Diff line change
`@@ -117,9 +117,11 @@ private function processDefinition(ContainerBuilder $container, $id, Definition`
`117`	`117`	`}`
`118`	`118`	`}`
`119`	`119`
	`120`	`+ $definition->setBindings($bindings);`
	`121`	`+`
`120`	`122`	`// reset fields with "merge" behavior`
`121`	`123`	`$abstract`
`122`		`- ->setBindings($bindings)`
	`124`	`+ ->setBindings(array())`
`123`	`125`	`->setArguments(array())`
`124`	`126`	`->setMethodCalls(array())`
`125`	`127`	`->setDecoratedService(null)`