minor #43647 [DependencyInjection] show class name on DI errors (hhoechtl)

fabpot · fabpot · commit 617a6128a67e · 2021-10-26T10:48:49.000+02:00
This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [DependencyInjection] show class name on DI errors #43645 | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #43645 | License | MIT Commits ------- b74c36a [DependencyInjection] show class name on DI errors
diff --git a/src/Symfony/Component/DependencyInjection/Definition.php b/src/Symfony/Component/DependencyInjection/Definition.php
@@ -265,15 +265,15 @@ public function addArgument($argument)
     public function replaceArgument($index, $argument)
     {
         if (0 === \count($this->arguments)) {
-            throw new OutOfBoundsException('Cannot replace arguments if none have been configured yet.');
+            throw new OutOfBoundsException(sprintf('Cannot replace arguments for class "%s" if none have been configured yet.', $this->class));
         }
 
         if (\is_int($index) && ($index < 0 || $index > \count($this->arguments) - 1)) {
-            throw new OutOfBoundsException(sprintf('The index "%d" is not in the range [0, %d].', $index, \count($this->arguments) - 1));
+            throw new OutOfBoundsException(sprintf('The index "%d" is not in the range [0, %d] of the arguments of class "%s".', $index, \count($this->arguments) - 1, $this->class));
         }
 
         if (!\array_key_exists($index, $this->arguments)) {
-            throw new OutOfBoundsException(sprintf('The argument "%s" doesn\'t exist.', $index));
+            throw new OutOfBoundsException(sprintf('The argument "%s" doesn\'t exist in class "%s".', $index, $this->class));
         }
 
         $this->arguments[$index] = $argument;
@@ -318,7 +318,7 @@ public function getArguments()
     public function getArgument($index)
     {
         if (!\array_key_exists($index, $this->arguments)) {
-            throw new OutOfBoundsException(sprintf('The argument "%s" doesn\'t exist.', $index));
+            throw new OutOfBoundsException(sprintf('The argument "%s" doesn\'t exist in class "%s".', $index, $this->class));
         }
 
         return $this->arguments[$index];

Original file line number	Diff line number	Diff line change
`@@ -265,15 +265,15 @@ public function addArgument($argument)`
`265`	`265`	`public function replaceArgument($index, $argument)`
`266`	`266`	`{`
`267`	`267`	`if (0 === \count($this->arguments)) {`
`268`		`- throw new OutOfBoundsException('Cannot replace arguments if none have been configured yet.');`
	`268`	`+ throw new OutOfBoundsException(sprintf('Cannot replace arguments for class "%s" if none have been configured yet.', $this->class));`
`269`	`269`	`}`
`270`	`270`
`271`	`271`	`if (\is_int($index) && ($index < 0 \|\| $index > \count($this->arguments) - 1)) {`
`272`		`- throw new OutOfBoundsException(sprintf('The index "%d" is not in the range [0, %d].', $index, \count($this->arguments) - 1));`
	`272`	`+ throw new OutOfBoundsException(sprintf('The index "%d" is not in the range [0, %d] of the arguments of class "%s".', $index, \count($this->arguments) - 1, $this->class));`
`273`	`273`	`}`
`274`	`274`
`275`	`275`	`if (!\array_key_exists($index, $this->arguments)) {`
`276`		`- throw new OutOfBoundsException(sprintf('The argument "%s" doesn\'t exist.', $index));`
	`276`	`+ throw new OutOfBoundsException(sprintf('The argument "%s" doesn\'t exist in class "%s".', $index, $this->class));`
`277`	`277`	`}`
`278`	`278`
`279`	`279`	`$this->arguments[$index] = $argument;`
`@@ -318,7 +318,7 @@ public function getArguments()`
`318`	`318`	`public function getArgument($index)`
`319`	`319`	`{`
`320`	`320`	`if (!\array_key_exists($index, $this->arguments)) {`
`321`		`- throw new OutOfBoundsException(sprintf('The argument "%s" doesn\'t exist.', $index));`
	`321`	`+ throw new OutOfBoundsException(sprintf('The argument "%s" doesn\'t exist in class "%s".', $index, $this->class));`
`322`	`322`	`}`
`323`	`323`
`324`	`324`	`return $this->arguments[$index];`