8000 [Form] Fixed infinite tests when ICU is available · symfony/symfony@61773de · GitHub
[go: up one dir, main page]
Skip to content

Commit 61773de

Browse files
webmozartfabpot
webmozart
authored and
fabpot
committed
[Form] Fixed infinite tests when ICU is available
1 parent 3cd1c9c commit 61773de

File tree

3 files changed

+20
-20
lines changed

3 files changed

+20
-20
lines changed

‎src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTimeTypeTest.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -433,8 +433,8 @@ public function testDateTypeChoiceErrorsBubbleUp()
433433

434434
$form['date']->addError($error);
435435

436-
$this->assertSame(array(), $form['date']->getErrors());
437-
$this->assertSame(array($error), $form->getErrors());
436+
$this->assertSame(array(), iterator_to_array($form['date']->getErrors()));
437+
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
438438
}
439439

440440
public function testDateTypeSingleTextErrorsBubbleUp()
@@ -446,8 +446,8 @@ public function testDateTypeSingleTextErrorsBubbleUp()
446446

447447
$form['date']->addError($error);
448448

449-
$this->assertSame(array(), $form['date']->getErrors());
450-
$this->assertSame(array($error), $form->getErrors());
449+
$this->assertSame(array(), iterator_to_array($form['date']->getErrors()));
450+
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
451451
}
452452

453453
public function testTimeTypeChoiceErrorsBubbleUp()
@@ -457,8 +457,8 @@ public function testTimeTypeChoiceErrorsBubbleUp()
457457

458458
$form['time']->addError($error);
459459

460-
$this->assertSame(array(), $form['time']->getErrors());
461-
$this->assertSame(array($error), $form->getErrors());
460+
$this->assertSame(array(), iterator_to_array($form['time 10000 ']->getErrors()));
461+
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
462462
}
463463

464464
public function testTimeTypeSingleTextErrorsBubbleUp()
@@ -470,8 +470,8 @@ public function testTimeTypeSingleTextErrorsBubbleUp()
470470

471471
$form['time']->addError($error);
472472

473-
$this->assertSame(array(), $form['time']->getErrors());
474-
$this->assertSame(array($error), $form->getErrors());
473+
$this->assertSame(array(), iterator_to_array($form['time']->getErrors()));
474+
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
475475
}
476476

477477
}

‎src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTypeTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -745,8 +745,8 @@ public function testYearErrorsBubbleUp($widget)
745745
));
746746
$form['year']->addError($error);
747747

748-
$this->assertSame(array(), $form['year']->getErrors());
749-
$this->assertSame(array($error), $form->getErrors());
748+
$this->assertSame(array(), iterator_to_array($form['year']->getErrors()));
749+
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
750750
}
751751

752752
/**
@@ -760,8 +760,8 @@ public function testMonthErrorsBubbleUp($widget)
760760
));
761761
$form['month']->addError($error);
762762

763-
$this->assertSame(array(), $form['month']->getErrors());
764-
$this->assertSame(array($error), $form->getErrors());
763+
$this->assertSame(array(), iterator_to_array($form['month']->getErrors()));
764+
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
765765
}
766766

767767
/**
@@ -775,8 +775,8 @@ public function testDayErrorsBubbleUp($widget)
775775
));
776776
$form['day']->addError($error);
777777

778-
$this->assertSame(array(), $form['day']->getErrors());
779-
$this->assertSame(array($error), $form->getErrors());
778+
$this->assertSame(array(), iterator_to_array($form['day']->getErrors()));
779+
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
780780
}
781781

782782
public function testYearsFor32BitsMachines()

‎src/Symfony/Component/Form/Tests/Extension/Core/Type/TimeTypeTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -601,8 +601,8 @@ public function testHourErrorsBubbleUp($widget)
601601
));
602602
$form['hour']->addError($error);
603603

604-
$this->assertSame(array(), $form['hour']->getErrors());
605-
$this->assertSame(array($error), $form->getErrors());
604+
$this->assertSame(array(), iterator_to_array($form['hour']->getErrors()));
605+
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
606606
}
607607

608608
/**
@@ -616,8 +616,8 @@ public function testMinuteErrorsBubbleUp($widget)
616616
));
617617
$form['minute']->addError($error);
618618

619-
$this->assertSame(array(), $form['minute']->getErrors());
620-
$this->assertSame(array($error), $form->getErrors());
619+
$this->assertSame(array(), iterator_to_array($form['minute']->getErrors()));
620+
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
621621
}
622622

623623
/**
@@ -632,8 +632,8 @@ public function testSecondErrorsBubbleUp($widget)
632632
));
633633
$form['second']->addError($error);
634634

635-
$this->assertSame(array(), $form['second']->getErrors());
636-
$this->assertSame(array($error), $form->getErrors());
635+
$this->assertSame(array(), iterator_to_array($form['second']->getErrors()));
636+
$this->assertSame(array($error), iterator_to_array($form->getErrors()));
637637
}
638638

639639
/**

0 commit comments

Comments
 (0)
0