[HttpFoundation][FrameworkBundle] Fix default locale is ignored when set_locale_from_accept_language is used

jkobus · jkobus · commit 61239714d3fb · 2023-12-27T10:08:56.000+01:00
diff --git a/src/Symfony/Component/HttpKernel/EventListener/LocaleListener.php b/src/Symfony/Component/HttpKernel/EventListener/LocaleListener.php
@@ -68,8 +68,8 @@ private function setLocale(Request $request): void
     {
         if ($locale = $request->attributes->get('_locale')) {
             $request->setLocale($locale);
-        } elseif ($this->useAcceptLanguageHeader && $request->getLanguages()) {
-            if ($preferredLanguage = $request->getPreferredLanguage($this->enabledLocales)) {
+        } elseif ($this->useAcceptLanguageHeader) {
+            if($request->getLanguages() && $preferredLanguage = $request->getPreferredLanguage($this->enabledLocales)) {
                 $request->setLocale($preferredLanguage);
             }
             $request->attributes->set('_vary_by_language', true);
diff --git a/src/Symfony/Component/HttpKernel/Tests/EventListener/LocaleListenerTest.php b/src/Symfony/Component/HttpKernel/Tests/EventListener/LocaleListenerTest.php
@@ -142,6 +142,17 @@ public function testRequestDefaultLocaleIfNoAcceptLanguageHeaderIsPresent()
         $this->assertEquals('de', $request->getLocale());
     }
 
+    public function testRequestVaryByLanguageAttributeIsSetIfUsingAcceptLanguageHeader()
+    {
+        $request = new Request();
+        $listener = new LocaleListener($this->requestStack, 'de', null, true, ['lt', 'de']);
+        $event = $this->getEvent($request);
+
+        $listener->setDefaultLocale($event);
+        $listener->onKernelRequest($event);
+        $this->assertSame(true, $request->attributes->get('_vary_by_language'));
+    }
+
     public function testRequestSecondPreferredLocaleFromAcceptLanguageHeader()
     {
         $request = Request::create('/');

Original file line number	Diff line number	Diff line change
`@@ -68,8 +68,8 @@ private function setLocale(Request $request): void`
`68`	`68`	`{`
`69`	`69`	`if ($locale = $request->attributes->get('_locale')) {`
`70`	`70`	`$request->setLocale($locale);`
`71`		`- } elseif ($this->useAcceptLanguageHeader && $request->getLanguages()) {`
`72`		`- if ($preferredLanguage = $request->getPreferredLanguage($this->enabledLocales)) {`
	`71`	`+ } elseif ($this->useAcceptLanguageHeader) {`
	`72`	`+ if($request->getLanguages() && $preferredLanguage = $request->getPreferredLanguage($this->enabledLocales)) {`
`73`	`73`	`$request->setLocale($preferredLanguage);`
`74`	`74`	`}`
`75`	`75`	`$request->attributes->set('_vary_by_language', true);`