bug #25978 Deterministic proxy names (lstrojny)

fabpot · fabpot · commit 5f770d77e86d · 2018-01-31T12:32:49.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- Deterministic proxy names Proxy class names should be deterministic and independent of spl_object_hash() which is somewhat random to better support reproducible builds. See #25958 | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- b173b81 Proxy class names should be deterministic and independent of spl_object_hash() which is somewhat random
diff --git a/src/Symfony/Bridge/ProxyManager/LazyProxy/PhpDumper/ProxyDumper.php b/src/Symfony/Bridge/ProxyManager/LazyProxy/PhpDumper/ProxyDumper.php
@@ -108,7 +108,7 @@ public function getProxyCode(Definition $definition)
      */
     private function getProxyClassName(Definition $definition)
     {
-        return preg_replace('/^.*\\\\/', '', $definition->getClass()).'_'.substr(hash('sha256', spl_object_hash($definition).$this->salt), -7);
+        return preg_replace('/^.*\\\\/', '', $definition->getClass()).'_'.substr(hash('sha256', $definition->getClass().$this->salt), -7);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ public function getProxyCode(Definition $definition)`
`108`	`108`	`*/`
`109`	`109`	`private function getProxyClassName(Definition $definition)`
`110`	`110`	`{`
`111`		`- return preg_replace('/^.*\\\\/', '', $definition->getClass()).'_'.substr(hash('sha256', spl_object_hash($definition).$this->salt), -7);`
	`111`	`+ return preg_replace('/^.*\\\\/', '', $definition->getClass()).'_'.substr(hash('sha256', $definition->getClass().$this->salt), -7);`
`112`	`112`	`}`
`113`	`113`
`114`	`114`	`/**`