8000 Mention generating absolute urls in UPGRADE files and CHANGELOG · symfony/symfony@5f506d9 · GitHub
[go: up one dir, main page]

Skip to content

Commit 5f506d9

Browse files
zdenekdrahosfabpot
authored andcommitted
Mention generating absolute urls in UPGRADE files and CHANGELOG
1 parent f8937bd commit 5f506d9

File tree

3 files changed

+68
-0
lines changed

3 files changed

+68
-0
lines changed

UPGRADE-2.8.md

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -630,3 +630,31 @@ HttpFoundation
630630
```php
631631
$request->query->get('foo')[bar];
632632
```
633+
634+
Routing
635+
-------
636+
637+
* Deprecated the hardcoded value for the `$referenceType` argument of the `UrlGeneratorInterface::generate` method.
638+
Use the constants defined in the `UrlGeneratorInterface` instead.
639+
640+
Before:
641+
642+
```php
643+
// url generated in controller
644+
$this->generateUrl('blog_show', array('slug' => 'my-blog-post'), true);
645+
646+
// url generated in @router service
647+
$router->generate('blog_show', array('slug' => 'my-blog-post'), true);
648+
```
649+
650+
After:
651+
652+
```php
653+
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
654+
655+
// url generated in controller
656+
$this->generateUrl('blog_show', array('slug' => 'my-blog-post'), UrlGeneratorInterface::ABSOLUTE_URL);
657+
658+
// url generated in @router service
659+
$router->generate('blog_show', array('slug' => 'my-blog-post'), UrlGeneratorInterface::ABSOLUTE_URL);
660+
```

UPGRADE-3.0.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -899,6 +899,30 @@ UPGRADE FROM 2.x to 3.0
899899
* The `getMatcherDumperInstance()` and `getGeneratorDumperInstance()` methods in the
900900
`Symfony\Component\Routing\Router` have been changed from `public` to `protected`.
901901

902+
* Use the constants defined in the UrlGeneratorInterface for the $referenceType argument of the UrlGeneratorInterface::generate method.
903+
904+
Before:
905+
906+
```php
907+
// url generated in controller
908+
$this->generateUrl('blog_show', array('slug' => 'my-blog-post'), true);
909+
910+
// url generated in @router service
911+
$router->generate('blog_show', array('slug' => 'my-blog-post'), true);
912+
```
913+
914+
After:
915+
916+
```php
917+
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
918+
919+
// url generated in controller
920+
$this->generateUrl('blog_show', array('slug' => 'my-blog-post'), UrlGeneratorInterface::ABSOLUTE_URL);
921+
922+
// url generated in @router service
923+
$router->generate('blog_show', array('slug' => 'my-blog-post'), UrlGeneratorInterface::ABSOLUTE_URL);
924+
```
925+
902926
### Security
903927

904928
* The `Resources/` directory was moved to `Core/Resources/`

src/Symfony/Component/Routing/CHANGELOG.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,22 @@ CHANGELOG
77
* allowed specifying a directory to recursively load all routing configuration files it contains
88
* Added ObjectRouteLoader and ServiceRouteLoader that allow routes to be loaded
99
by calling a method on an object/service.
10+
* [DEPRECATION] Deprecated the hardcoded value for the `$referenceType` argument of the `UrlGeneratorInterface::generate` method.
11+
Use the constants defined in the `UrlGeneratorInterface` instead.
12+
13+
Before:
14+
15+
```php
16+
$router->generate('blog_show', array('slug' => 'my-blog-post'), true);
17+
```
18+
19+
After:
20+
21+
```php
22+
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
23+
24+
$router->generate('blog_show', array('slug' => 'my-blog-post'), UrlGeneratorInterface::ABSOLUTE_URL);
25+
```
1026

1127
2.5.0
1228
-----

0 commit comments

Comments
 (0)
0