Deprecate TwigRendererEngine::setEnvironment()

chalasr · chalasr · commit 5ef156527ff1 · 2016-12-22T11:53:24.000+01:00
diff --git a/UPGRADE-4.0.md b/UPGRADE-4.0.md
@@ -217,6 +217,9 @@ TwigBridge
  * The possibility to inject the Form Twig Renderer into the form extension
    has been removed. Inject it into the `TwigRendererEngine` instead.
 
+ * The `TwigRendererEngine::setEnvironment()` method has been removed.
+   Pass the Twig Environment as second argument of the constructor instead.
+
 Validator
 ---------
 
diff --git a/src/Symfony/Bridge/Twig/Form/TwigRendererEngine.php b/src/Symfony/Bridge/Twig/Form/TwigRendererEngine.php
@@ -41,9 +41,15 @@ public function __construct(array $defaultThemes = array(), \Twig_Environment $e
 
     /**
      * {@inheritdoc}
+     *
+     * @deprecated since version 3.3, to be removed in 4.0
      */
     public function setEnvironment(\Twig_Environment $environment)
     {
+        if ($this->environment) {
+            @trigger_error(sprintf('The "%s()" method is deprecated since version 3.3 and will be removed in 4.0. Pass the Twig Environment as second argument of the constructor instead.', __METHOD__), E_USER_DEPRECATED);
+        }
+
         $this->environment = $environment;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -41,9 +41,15 @@ public function __construct(array $defaultThemes = array(), \Twig_Environment $e`
`41`	`41`
`42`	`42`	`/**`
`43`	`43`	`* {@inheritdoc}`
	`44`	`+ *`
	`45`	`+ * @deprecated since version 3.3, to be removed in 4.0`
`44`	`46`	`*/`
`45`	`47`	`public function setEnvironment(\Twig_Environment $environment)`
`46`	`48`	`{`
	`49`	`+ if ($this->environment) {`
	`50`	`+ @trigger_error(sprintf('The "%s()" method is deprecated since version 3.3 and will be removed in 4.0. Pass the Twig Environment as second argument of the constructor instead.', __METHOD__), E_USER_DEPRECATED);`
	`51`	`+ }`
	`52`	`+`
`47`	`53`	`$this->environment = $environment;`
`48`	`54`	`}`
`49`	`55`