8000 bug #28388 [DI] configure inlined services before injecting them when… · symfony/symfony@5e237db · GitHub
[go: up one dir, main page]
Skip to content

Commit 5e237db

Browse files
nicolas-grekasnicolas-grekas
committed
bug #28388 [DI] configure inlined services before injecting them when dumping the container (nicolas-grekas)
This PR was merged into the 3.4 branch. Discussion ---------- [DI] configure inlined services before injecting them when dumping the container | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28304 | License | MIT | Doc PR | - #28060 introduced a change in the way inline services are dumped: these instances could end up being configured *after* being injected. This breaks e.g. using Doctrine's Configuration instances, which are expected to be fully defined before being injected into their consumers. Fixing this required a significant refactorization because I was just unable to reason with the heavily scrambled logic in place right now. The new logic is still non-trivial, but at least it's manageable, thus easier to get correct. (Replaces #28385 which is the same applied to 4.1 - should help with merges.) Commits ------- e5c5405 [DI] configure inlined services before injecting them when dumping the container
2 parents 5632dc7 + e5c5405 commit 5e237db

File tree

6 files changed

+184
-312
lines changed

6 files changed

+184
-312
lines changed

0 commit comments

Comments
 (0)
0