[Security] Delete old session on auth strategy migrate

xelaris · xelaris · commit 5dd11e67a4c7 · 2014-12-20T02:42:01.000+01:00
diff --git a/src/Symfony/Component/Security/Http/Session/SessionAuthenticationStrategy.php b/src/Symfony/Component/Security/Http/Session/SessionAuthenticationStrategy.php
@@ -47,7 +47,7 @@ public function onAuthentication(Request $request, TokenInterface $token)
                 return;
 
             case self::MIGRATE:
-                $request->getSession()->migrate();
+                $request->getSession()->migrate(true);
 
                 return;
 
diff --git a/src/Symfony/Component/Security/Tests/Http/Session/SessionAuthenticationStrategyTest.php b/src/Symfony/Component/Security/Tests/Http/Session/SessionAuthenticationStrategyTest.php
@@ -47,7 +47,7 @@ public function testUnsupportedStrategy()
     public function testSessionIsMigrated()
     {
         $session = $this->getMock('Symfony\Component\HttpFoundation\Session\SessionInterface');
-        $session->expects($this->once())->method('migrate');
+        $session->expects($this->once())->method('migrate')->with($this->equalTo(true));
 
         $strategy = new SessionAuthenticationStrategy(SessionAuthenticationStrategy::MIGRATE);
         $strategy->onAuthentication($this->getRequest($session), $this->getToken());

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public function testUnsupportedStrategy()`
`47`	`47`	`public function testSessionIsMigrated()`
`48`	`48`	`{`
`49`	`49`	`$session = $this->getMock('Symfony\Component\HttpFoundation\Session\SessionInterface');`
`50`		`- $session->expects($this->once())->method('migrate');`
	`50`	`+ $session->expects($this->once())->method('migrate')->with($this->equalTo(true));`
`51`	`51`
`52`	`52`	`$strategy = new SessionAuthenticationStrategy(SessionAuthenticationStrategy::MIGRATE);`
`53`	`53`	`$strategy->onAuthentication($this->getRequest($session), $this->getToken());`