8000 minor #24829 [SecurityBundle] Fix the datacollector to properly suppo… · symfony/symfony@5dcd82c · GitHub
[go: up one dir, main page]

Skip to content

Commit 5dcd82c

Browse files
committed
minor #24829 [SecurityBundle] Fix the datacollector to properly support decision.object being null (ogizanagi)
This PR was merged into the 3.3 branch. Discussion ---------- [SecurityBundle] Fix the datacollector to properly support decision.object being null | Q | A | ------------- | --- | Branch? | 3.3 <!-- see comment below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #24804 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Similar to #23050, when accessing a `Data` clone property through `__get()` and the value is `null` for instance, you'll really get `null` instead of a `Data` instance. The solution is to use `seek` instead whenever we access and try to use `profiler_dump` on a `Data` property that can be a simple scalar like `null` or `false`. AFAIK, `decision.object` is the only one here. Commits ------- 769a5f2 [SecurityBundle] Fix the datacollector to properly support decision.object being null
2 parents cbd42f7 + 769a5f2 commit 5dcd82c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Symfony/Bundle/SecurityBundle/Resources/views/Collector/security.html.twig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@
264264
{{ profiler_dump(decision.attributes) }}
265265
{% endif %}
266266
</td>
267-
<td>{{ profiler_dump(decision.object) }}</td>
267+
<td>{{ profiler_dump(decision.seek('object')) }}</td>
268268
</tr>
269269
{% endfor %}
270270
</tbody>

0 commit comments

Comments
 (0)
0