Fix expected missing return types

nicolas-grekas · nicolas-grekas · commit 5d992a14b7ab · 2024-08-30T18:23:38.000+02:00
diff --git a/.github/expected-missing-return-types.diff b/.github/expected-missing-return-types.diff
@@ -20,21 +20,35 @@ diff --git a/src/Symfony/Bridge/Twig/Tests/Extension/AbstractLayoutTestCase.php
 diff --git a/src/Symfony/Component/BrowserKit/AbstractBrowser.php b/src/Symfony/Component/BrowserKit/AbstractBrowser.php
 --- a/src/Symfony/Component/BrowserKit/AbstractBrowser.php
 +++ b/src/Symfony/Component/BrowserKit/AbstractBrowser.php
-@@ -466,5 +466,5 @@ abstract class AbstractBrowser
+@@ -420,5 +420,5 @@ abstract class AbstractBrowser
+      * @throws \RuntimeException When processing returns exit code
+      */
+-    protected function doRequestInProcess(object $request)
++    protected function doRequestInProcess(object $request): object
+     {
+         $deprecationsFile = tempnam(sys_get_temp_dir(), 'deprec');
+@@ -457,5 +457,5 @@ abstract class AbstractBrowser
+      * @psalm-return TResponse
+      */
+-    abstract protected function doRequest(object $request);
++    abstract protected function doRequest(object $request): object;
+ 
+     /**
+@@ -470,5 +470,5 @@ abstract class AbstractBrowser
       * @throws LogicException When this abstract class is not implemented
       */
 -    protected function getScript(object $request)
 +    protected function getScript(object $request): string
      {
          throw new LogicException('To insulate requests, you need to override the getScript() method.');
-@@ -478,5 +478,5 @@ abstract class AbstractBrowser
+@@ -482,5 +482,5 @@ abstract class AbstractBrowser
       * @psalm-return TRequest
       */
 -    protected function filterRequest(Request $request)
 +    protected function filterRequest(Request $request): object
      {
          return $request;
-@@ -490,5 +490,5 @@ abstract class AbstractBrowser
+@@ -494,5 +494,5 @@ abstract class AbstractBrowser
       * @return Response
       */
 -    protected function filterResponse(object $response)
diff --git a/src/Symfony/Component/BrowserKit/AbstractBrowser.php b/src/Symfony/Component/BrowserKit/AbstractBrowser.php
@@ -413,6 +413,8 @@ public function request(string $method, string $uri, array $parameters = [], arr
      *
      * @psalm-param TRequest $request
      *
+     * @return object
+     *
      * @psalm-return TResponse
      *
      * @throws \RuntimeException When processing returns exit code
@@ -450,6 +452,8 @@ protected function doRequestInProcess(object $request)
      *
      * @psalm-param TRequest $request
      *
+     * @return object
+     *
      * @psalm-return TResponse
      */
     abstract protected function doRequest(object $request);

Original file line number	Diff line number	Diff line change
`@@ -413,6 +413,8 @@ public function request(string $method, string $uri, array $parameters = [], arr`
`413`	`413`	`*`
`414`	`414`	`* @psalm-param TRequest $request`
`415`	`415`	`*`
	`416`	`+ * @return object`
	`417`	`+ *`
`416`	`418`	`* @psalm-return TResponse`
`417`	`419`	`*`
`418`	`420`	`* @throws \RuntimeException When processing returns exit code`
`@@ -450,6 +452,8 @@ protected function doRequestInProcess(object $request)`
`450`	`452`	`*`
`451`	`453`	`* @psalm-param TRequest $request`
`452`	`454`	`*`
	`455`	`+ * @return object`
	`456`	`+ *`
`453`	`457`	`* @psalm-return TResponse`
`454`	`458`	`*/`
`455`	`459`	`abstract protected function doRequest(object $request);`