8000 minor #29396 fix type for $value in DocBlock (rudidude86) · symfony/symfony@5d0c93b · GitHub
[go: up one dir, main page]

Skip to content

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 5d0c93b

Browse files
minor #29396 fix type for $value in DocBlock (rudidude86)
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #29396). Discussion ---------- fix type for $value in DocBlock `$value` is supposed to be a string, not an int, according to [`NumberFormatter::setTextAttribute()` documentation](https://secure.php.net/manual/en/numberformatter.settextattribute.php) | Q | A | ------------- | --- | Branch? | master for features / 3.4 up to 4.2 for bug fixes <!-- see below --> | Bug fix? | yes/no | New feature? | yes/no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- ff2431a fix type for $value in DocBlock
2 parents 6c3c47e + ff2431a commit 5d0c93b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Symfony/Component/Intl/NumberFormatter/NumberFormatter.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,7 +639,7 @@ public function setSymbol($attr, $value)
639639
* Not supported. Set a text attribute.
640640
*
641641
* @param int $attr An attribute specifier, one of the text attribute constants
642-
* @param int $value The attribute value
642+
* @param string $value The attribute value
643643
*
644644
* @return bool true on success or false on failure
645645
*

0 commit comments

Comments
 (0)
0