minor #50386 Fix cursor on link that has no href (PhilETaylor)

nicolas-grekas · nicolas-grekas · commit 5bf5c4d5b77a · 2023-05-23T10:57:25.000+02:00
This PR was merged into the 6.3 branch. Discussion ---------- Fix cursor on link that has no href [WebProfilerBundle] Fix cursor on link that has no href link to button | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no  | Deprecations? | no  Alternative approach for #50376 `@stof` `@nicolas`-grekas Commits ------- 893d299 Convert A link to Button
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/messenger.html.twig b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/messenger.html.twig
@@ -154,7 +154,7 @@
                     {% else %}
                         {{ caller.name }}
                     {% endif %}
-                    line <a class="text-small sf-toggle" data-toggle-selector="#sf-trace-{{ discr }}-{{ loop.index0 }}" style="cursor: pointer">{{ caller.line }}</a>
+                    line <button type="button" class="btn-link text-small sf-toggle" data-toggle-selector="#sf-trace-{{ discr }}-{{ loop.index0 }}">{{ caller.line }}</button>
 
                     <div class="hidden" id="sf-trace-{{ discr }}-{{ loop.index0 }}">
                         <div class="trace">
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/validator.html.twig b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/validator.html.twig
@@ -83,7 +83,7 @@
                 {% else %}
                     {{ caller.name }}
                 {% endif %}
-                line <a class="text-small sf-toggle" data-toggle-selector="#sf-trace-{{ loop.index0 }}" style="cursor: pointer">{{ caller.line }}</a> (<a class="text-small sf-toggle" data-toggle-selector="#sf-context-{{ loop.index0 }}" style="cursor: pointer">context</a>):
+                line <button type="button" class="btn-link text-small sf-toggle" data-toggle-selector="#sf-trace-{{ loop.index0 }}">{{ caller.line }}</button> (<button type="button" class="btn-link text-small sf-toggle" data-toggle-selector="#sf-context-{{ loop.index0 }}">context</button>):
             </span>
 
             <div class="sf-validator-compact hidden" id="sf-trace-{{ loop.index0 }}">
