feature #58074 [Console][Process] Add $verbosity argument to mustRun helper method (willrowe)

nicolas-grekas · nicolas-grekas · commit 5b353284bee5 · 2024-08-30T17:40:38.000+02:00
This PR was squashed before being merged into the 7.2 branch. Discussion ---------- [Console][Process] Add `$verbosity` argument to `mustRun` helper method | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | License | MIT This adds a 'verbosity' argument to 'mustRun' in order to match 'run'. There are no existing tests for 'mustRun', just 'run'. Commits ------- 5eb76bf [Console][Process] Add `$verbosity` argument to `mustRun` helper method
diff --git a/src/Symfony/Component/Console/CHANGELOG.md b/src/Symfony/Component/Console/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 ---
 
  * Add support for `FORCE_COLOR` environment variable
+ * Add `verbosity` argument to `mustRun` process helper method
 
 7.1
 ---
diff --git a/src/Symfony/Component/Console/Helper/ProcessHelper.php b/src/Symfony/Component/Console/Helper/ProcessHelper.php
@@ -94,9 +94,9 @@ public function run(OutputInterface $output, array|Process $cmd, ?string $error
      *
      * @see run()
      */
-    public function mustRun(OutputInterface $output, array|Process $cmd, ?string $error = null, ?callable $callback = null): Process
+    public function mustRun(OutputInterface $output, array|Process $cmd, ?string $error = null, ?callable $callback = null, int $verbosity = OutputInterface::VERBOSITY_VERY_VERBOSE): Process
     {
-        $process = $this->run($output, $cmd, $error, $callback);
+        $process = $this->run($output, $cmd, $error, $callback, $verbosity);
 
         if (!$process->isSuccessful()) {
             throw new ProcessFailedException($process);

Original file line number	Diff line number	Diff line change
`@@ -94,9 +94,9 @@ public function run(OutputInterface $output, array\|Process $cmd, ?string $error`
`94`	`94`	`*`
`95`	`95`	`* @see run()`
`96`	`96`	`*/`
`97`		`- public function mustRun(OutputInterface $output, array\|Process $cmd, ?string $error = null, ?callable $callback = null): Process`
	`97`	`+ public function mustRun(OutputInterface $output, array\|Process $cmd, ?string $error = null, ?callable $callback = null, int $verbosity = OutputInterface::VERBOSITY_VERY_VERBOSE): Process`
`98`	`98`	`{`
`99`		`- $process = $this->run($output, $cmd, $error, $callback);`
	`99`	`+ $process = $this->run($output, $cmd, $error, $callback, $verbosity);`
`100`	`100`
`101`	`101`	`if (!$process->isSuccessful()) {`
`102`	`102`	`throw new ProcessFailedException($process);`