8000 [Notifier] Fix GoIpTransport · symfony/symfony@5afb93c · GitHub
[go: up one dir, main page]
Skip to content

Commit 5afb93c

Browse files
nicolas-grekasnicolas-grekas
committed
[Notifier] Fix GoIpTransport
1 parent 5cc07e7 commit 5afb93c

File tree

3 files changed

+6
-17
lines changed

3 files changed

+6
-17
lines changed

‎src/Symfony/Component/HttpFoundation/Tests/RequestTest.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2668,16 +2668,6 @@ public function testReservedFlags()
26682668
$this->assertNotSame(0b10000000, $value, sprintf('The constant "%s" should not use the reserved value "0b10000000".', $constant));
26692669
}
26702670
}
2671-
2672-
/**
2673-
* @group legacy
2674-
*/
2675-
public function testInvalidUriCreationDeprecated()
2676-
{
2677-
$this->expectDeprecation('Since symfony/http-foundation 6.3: Calling "Symfony\Component\HttpFoundation\Request::create()" with an invalid URI is deprecated.');
2678-
$request = Request::create('/invalid-path:123');
2679-
$this->assertEquals('http://localhost/invalid-path:123', $request->getUri());
2680-
}
26812671
}
26822672

26832673
class RequestContentProxy extends Request

‎src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/ConnectionTest.php

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ public function testFromDsnWithMixDsnQueryOptions()
106106

107107
$this->assertEquals(
108108
Connection::fromDsn('redis://localhost/queue/group1/consumer1', ['consumer' => 'specific-consumer'], $this->createRedisMock()),
109-
Connection::fromDsn('redis://localhost/queue/group1/consumer1', [], $this->createRedisMock()))
109+
Connection::fromDsn('redis://localhost/queue/group1/consumer1', [], $this->createRedisMock())
110110
);
111111
}
112112

@@ -439,8 +439,7 @@ public function testFromDsnOnUnixSocketWithUserAndPassword()
439439
'delete_after_ack' => true,
440440
'host' => '/var/run/redis/redis.sock',
441441
'port' => 0,
442-
'user' => 'user',
443-
'pass' => 'password',
442+
'auth' => ['user', 'password'],
444443
], $redis),
445444
Connection::fromDsn('redis://user:password@/var/run/redis/redis.sock', ['stream' => 'queue', 'delete_after_ack' => true], $redis)
446445
);
@@ -460,7 +459,7 @@ public function testFromDsnOnUnixSocketWithPassword()
460459
'delete_after_ack' => true,
461460
'host' => '/var/run/redis/redis.sock',
462461
'port' => 0,
463-
'pass' => 'password',
462+
'auth' => 'password',
464463
], $redis),
465464
Connection::fromDsn('redis://password@/var/run/redis/redis.sock', ['stream' => 'queue', 'delete_after_ack' => true], $redis)
466465
);
@@ -480,7 +479,7 @@ public function testFromDsnOnUnixSocketWithUser()
480479
'delete_after_ack' => true,
481480
'host' => '/var/run/redis/redis.sock',
482481
'port' => 0,
483-
'user' => 'user',
482+
'auth' => 'user',
484483
], $redis),
485484
Connection::fromDsn('redis://user:@/var/run/redis/redis.sock', ['stream' => 'queue', 'delete_after_ack' => true], $redis)
486485
);
@@ -494,7 +493,7 @@ private function createRedisMock(): \Redis
494493
->willReturn(true);
495494
$redis->expects($this->any())
496495
->method('isConnected')
497-
->willReturnOnConsecutiveCalls(false, true);
496+
->willReturnOnConsecutiveCalls(false, true, true);
498497

499498
return $redis;
500499
}

‎src/Symfony/Component/Notifier/Bridge/GoIp/GoIpTransport.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ protected function doSend(MessageInterface $message): SentMessage
7171
throw new LogicException(sprintf('The "%s" transport does not support the "From" option.', __CLASS__));
7272
}
7373

74-
$response = $this->client->request('GET', $this->getEndpoint(), [
74+
$response = $this->client->request('GET', 'https://'.$this->getEndpoint(), [
7575
'query' => [
7676
'u' => $this->username,
7777
'p' => $this->password,

0 commit comments

Comments
 (0)
0