Use is_subclass_of instead of reflection

GuilhemN · GuilhemN · commit 5af5d06f2e5a · 2016-01-16T14:49:28.000+01:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/AddConsoleCommandPass.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/AddConsoleCommandPass.php
@@ -37,8 +37,7 @@ public function process(ContainerBuilder $container)
             }
 
             $class = $container->getParameterBag()->resolveValue($definition->getClass());
-            $r = new \ReflectionClass($class);
-            if (!$r->isSubclassOf('Symfony\\Component\\Console\\Command\\Command')) {
+            if (!is_subclass_of($class, 'Symfony\\Component\\Console\\Command\\Command')) {
                 throw new \InvalidArgumentException(sprintf('The service "%s" tagged "console.command" must be a subclass of "Symfony\\Component\\Console\\Command\\Command".', $id));
             }
             $container->setAlias('console.command.'.strtolower(str_replace('\\', '_', $class)), $id);

Original file line number	Diff line number	Diff line change
`@@ -37,8 +37,7 @@ public function process(ContainerBuilder $container)`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`$cl 5E75 ass = $container->getParameterBag()->resolveValue($definition->getClass());`
`40`		`- $r = new \ReflectionClass($class);`
`41`		`- if (!$r->isSubclassOf('Symfony\\Component\\Console\\Command\\Command')) {`
	`40`	`+ if (!is_subclass_of($class, 'Symfony\\Component\\Console\\Command\\Command')) {`
`42`	`41`	`throw new \InvalidArgumentException(sprintf('The service "%s" tagged "console.command" must be a subclass of "Symfony\\Component\\Console\\Command\\Command".', $id));`
`43`	`42`	`}`
`44`	`43`	`$container->setAlias('console.command.'.strtolower(str_replace('\\', '_', $class)), $id);`