bug #26649 [Messenger] Remove the default transport if no serializer service (sroze)

sroze · sroze · commit 5acc51f5f750 · 2018-03-26T20:58:57.000+01:00
This PR was merged into the 4.1-dev branch. Discussion ---------- [Messenger] Remove the default transport if no `serializer` service | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT If the `serializer` service does not exist, we remove the default transport services as they rely on it. Commits ------- 2bcf93d Remove the default transport if no serializer
diff --git a/src/Symfony/Component/Messenger/DependencyInjection/MessengerPass.php b/src/Symfony/Component/Messenger/DependencyInjection/MessengerPass.php
@@ -51,6 +51,12 @@ public function process(ContainerBuilder $container)
             $container->removeDefinition('messenger.middleware.debug.logging');
         }
 
+        if (!$container->has('serializer')) {
+            $container->removeDefinition('messenger.transport.serialize_message_with_type_in_headers');
+            $container->removeAlias('messenger.transport.default_encoder');
+            $container->removeAlias('messenger.transport.default_decoder');
+        }
+
         $this->registerReceivers($container);
         $this->registerHandlers($container);
     }

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,12 @@ public function process(ContainerBuilder $container)`
`51`	`51`	`$container->removeDefinition('messenger.middleware.debug.logging');`
`52`	`52`	`}`
`53`	`53`
	`54`	`+ if (!$container->has('serializer')) {`
	`55`	`+ $container->removeDefinition('messenger.transport.serialize_message_with_type_in_headers');`
	`56`	`+ $container->removeAlias('messenger.transport.default_encoder');`
	`57`	`+ $container->removeAlias('messenger.transport.default_decoder');`
	`58`	`+ }`
	`59`	`+`
`54`	`60`	`$this->registerReceivers($container);`
`55`	`61`	`$this->registerHandlers($container);`
`56`	`62`	`}`