8000 Review · symfony/symfony@5a940e5 · GitHub
[go: up one dir, main page]
Skip to content

Commit 5a940e5

Browse files
noniagriconomienoniagriconomie
committed
Review
1 parent 8c099a8 commit 5a940e5

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

‎src/Symfony/Component/HttpKernel/DataCollector/ConfigDataCollector.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ public function getSymfonyMinorVersion()
175175
*
176176
* @return bool
177177
*/
178-
public function isSymfonyLts()
178+
public function isSymfonyLts(): bool
179179
{
180180
return $this->data['symfony_lts'];
181181
}

‎src/Symfony/Component/HttpKernel/Tests/DataCollector/ConfigDataCollectorTest.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,7 @@ public function testCollect()
3636
$this->assertSame(class_exists('Locale', false) && \Locale::getDefault() ? \Locale::getDefault() : 'n/a', $c->getPhpIntlLocale());
3737
$this->assertSame(date_default_timezone_get(), $c->getPhpTimezone());
3838
$this->assertSame(Kernel::VERSION, $c->getSymfonyVersion());
39-
$isSymfonyLts = $c->isSymfonyLts();
40-
(4 === Kernel::MINOR_VERSION)
41-
? $this->assertTrue($isSymfonyLts)
42-
: $this->assertFalse($isSymfonyLts);
39+
$this->assertSame(4 === Kernel::MINOR_VERSION, $c->isSymfonyLts());
4340
$this->assertNull($c->getToken());
4441
$this->assertSame(\extension_loaded('xdebug'), $c->hasXDebug());
4542
$this->assertSame(\extension_loaded('Zend OPcache') && filter_var(ini_get('opcache.enable'), FILTER_VALIDATE_BOOLEAN), $c->hasZendOpcache());

0 commit comments

Comments
 (0)
0