[Mailer][Postmark][Webhook] Make allowed IPs configurable

aleho · aleho · commit 5a2bcddbd40c · 2024-02-08T18:32:47.000+01:00
Adding "127.0.0.1" to webhooks doesn't always cut it. Testing in e.g.
dockerized setups the IP address will most certainly not be 127.0.0.1
when testing requests originate from the host.
diff --git a/src/Symfony/Component/Mailer/Bridge/Postmark/Webhook/PostmarkRequestParser.php b/src/Symfony/Component/Mailer/Bridge/Postmark/Webhook/PostmarkRequestParser.php
@@ -27,16 +27,18 @@ final class PostmarkRequestParser extends AbstractRequestParser
 {
     public function __construct(
         private readonly PostmarkPayloadConverter $converter,
+
+        // https://postmarkapp.com/support/article/800-ips-for-firewalls#webhooks
+        // localhost is added for testing
+        private readonly array $allowedIPs = ['3.134.147.250', '50.31.156.6', '50.31.156.77', '18.217.206.57', '127.0.0.1'],
     ) {
     }
 
     protected function getRequestMatcher(): RequestMatcherInterface
     {
         return new ChainRequestMatcher([
             new MethodRequestMatcher('POST'),
-            // https://postmarkapp.com/support/article/800-ips-for-firewalls#webhooks
-            // localhost is added for testing
-            new IpsRequestMatcher(['3.134.147.250', '50.31.156.6', '50.31.156.77', '18.217.206.57', '127.0.0.1']),
+            new IpsRequestMatcher($this->allowedIPs),
             new IsJsonRequestMatcher(),
         ]);
     }

Original file line number	Diff line number	Diff line change
`@@ -27,16 +27,18 @@ final class PostmarkRequestParser extends AbstractRequestParser`
`27`	`27`	`{`
`28`	`28`	`public function __construct(`
`29`	`29`	`private readonly PostmarkPayloadConverter $converter,`
	`30`	`+`
	`31`	`+ // https://postmarkapp.com/support/article/800-ips-for-firewalls#webhooks`
	`32`	`+ // localhost is added for testing`
	`33`	`+ private readonly array $allowedIPs = ['3.134.147.250', '50.31.156.6', '50.31.156.77', '18.217.206.57', '127.0.0.1'],`
`30`	`34`	`) {`
`31`	`35`	`}`
`32`	`36`
`33`	`37`	`protected function getRequestMatcher(): RequestMatcherInterface`
`34`	`38`	`{`
`35`	`39`	`return new ChainRequestMatcher([`
`36`	`40`	`new MethodRequestMatcher('POST'),`
`37`		`- // https://postmarkapp.com/support/article/800-ips-for-firewalls#webhooks`
`38`		`- // localhost is added for testing`
`39`		`- new IpsRequestMatcher(['3.134.147.250', '50.31.156.6', '50.31.156.77', '18.217.206.57', '127.0.0.1']),`
	`41`	`+ new IpsRequestMatcher($this->allowedIPs),`
`40`	`42`	`new IsJsonRequestMatcher(),`
`41`	`43`	`]);`
`42`	`44`	`}`