8000 [HttpFoundation] Add a dependency on the mbstring polyfill · symfony/symfony@59b9f15 · GitHub
[go: up one dir, main page]

Skip to content

Commit 59b9f15

Browse files
jakzalnicolas-grekas
authored andcommitted
[HttpFoundation] Add a dependency on the mbstring polyfill
1 parent 4f224ef commit 59b9f15

File tree

4 files changed

+10
-2
lines changed

4 files changed

+10
-2
lines changed

composer.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"doctrine/common": "~2.4",
2121
"paragonie/random_compat": "~1.0",
2222
"symfony/polyfill-apcu": "~1.1",
23+
"symfony/polyfill-mbstring": "~1.1",
2324
"twig/twig": "~1.23|~2.0",
2425
"psr/log": "~1.0"
2526
},

src/Symfony/Component/HttpFoundation/Tests/BinaryFileResponseTest.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,13 @@ public function testConstruction()
3636

3737
public function testConstructWithNonAsciiFilename()
3838
{
39-
new BinaryFileResponse(__DIR__.'/Fixtures/föö.html', 200, array(), true, 'attachment');
39+
touch(sys_get_temp_dir().'/fööö.html');
40+
41+
$response = new BinaryFileResponse(sys_get_temp_dir().'/fööö.html', 200, array(), true, 'attachment');
42+
43+
@unlink(sys_get_temp_dir().'/fööö.html');
44+
45+
$this->assertSame('fööö.html', $response->getFile()->getFilename());
4046
}
4147

4248
/**

src/Symfony/Component/HttpFoundation/Tests/Fixtures/föö.html

Whitespace-only changes.

src/Symfony/Component/HttpFoundation/composer.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@
1616
}
1717
],
1818
"require": {
19-
"php": ">=5.3.3"
19+
"php": ">=5.3.3",
20+
"symfony/polyfill-mbstring": "~1.1"
2021
},
2122
"autoload": {
2223
"psr-0": { "Symfony\\Component\\HttpFoundation\\": "" },

0 commit comments

Comments
 (0)
0