minor #30296 [VarDumper] link paths in stack traces to IDE (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 5909a4766478 · 2019-02-19T14:25:47.000+01:00
This PR was merged into the 4.3-dev branch. Discussion ---------- [VarDumper] link paths in stack traces to IDE | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | not really | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - `./test.php:8` and `./test.php:11` can now be clicked: ![image](https://user-images.githubusercontent.com/243674/52971041-466b1c80-33b6-11e9-9bc1-0e55dc115f63.png) Commits ------- 6672ac3 [VarDumper] link paths in stack traces to IDE
diff --git a/src/Symfony/Component/VarDumper/Caster/ExceptionCaster.php b/src/Symfony/Component/VarDumper/Caster/ExceptionCaster.php
@@ -236,7 +236,7 @@ public static function castFrameStub(FrameStub $frame, array $a, Stub $stub, $is
                             $ellipsis += 1 + \strlen($f['line']);
                         }
                     }
-                    $srcAttr .= '&separator= ';
+                    $srcAttr .= sprintf('&separator= &file=%s&line=%d', rawurlencode($f['file']), $f['line']);
                 } else {
                     $srcAttr .= '&separator=:';
                 }

Original file line number	Diff line number	Diff line change
`@@ -236,7 +236,7 @@ public static function castFrameStub(FrameStub $frame, array $a, Stub $stub, $is`
`236`	`236`	`$ellipsis += 1 + \strlen($f['line']);`
`237`	`237`	`}`
`238`	`238`	`}`
`239`		`- $srcAttr .= '&separator= ';`
	`239`	`+ $srcAttr .= sprintf('&separator= &file=%s&line=%d', rawurlencode($f['file']), $f['line']);`
`240`	`240`	`} else {`
`241`	`241`	`$srcAttr .= '&separator=:';`
`242`	`242`	`}`