Update src/Symfony/Component/Security/Http/RateLimiter/DefaultLoginRateLimiter.php

Spomky · mtarld · web-flow · commit 589e4970db91 · 2023-08-22T20:14:14.000+02:00
Co-authored-by: Mathias Arlaud &lt;mathias.arlaud@gmail.com&gt;
diff --git a/src/Symfony/Component/Security/Http/RateLimiter/DefaultLoginRateLimiter.php b/src/Symfony/Component/Security/Http/RateLimiter/DefaultLoginRateLimiter.php
@@ -35,7 +35,7 @@ final class DefaultLoginRateLimiter extends AbstractRequestRateLimiter
      */
     public function __construct(RateLimiterFactory $globalFactory, RateLimiterFactory $localFactory, #[\SensitiveParameter] string $secret = '')
     {
-        if (!$secret) {
+        if ('' === $secret) {
             trigger_deprecation('symfony/security-http', '6.4', 'Calling "%s()" with an empty secret is deprecated. A non-empty secret will be mandatory in version 7.0.', __METHOD__);
             // throw new \Symfony\Component\Security\Core\Exception\InvalidArgumentException('A non-empty secret is required.');
         }

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ final class DefaultLoginRateLimiter extends AbstractRequestRateLimiter`
`35`	`35`	`*/`
`36`	`36`	`public function __construct(RateLimiterFactory $globalFactory, RateLimiterFactory $localFactory, #[\SensitiveParameter] string $secret = '')`
`37`	`37`	`{`
`38`		`- if (!$secret) {`
	`38`	`+ if ('' === $secret) {`
`39`	`39`	`trigger_deprecation('symfony/security-http', '6.4', 'Calling "%s()" with an empty secret is deprecated. A non-empty secret will be mandatory in version 7.0.', __METHOD__);`
`40`	`40`	`// throw new \Symfony\Component\Security\Core\Exception\InvalidArgumentException('A non-empty secret is required.');`
`41`	`41`	`}`