feature #51756 [Messenger] RejectRedeliveredMessageException should not be retried (nikophil)

fabpot · fabpot · commit 5872615f0c73 · 2023-09-30T19:44:20.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [Messenger] RejectRedeliveredMessageException should not be retried | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | License | MIT | Doc PR | I think it is not needed Hello, when a `RejectRedeliveredMessageException` is thrown once, it is actually retried because it does not implement `UnrecoverableExceptionInterface` but we know it will always because the stamp `AmqpReceivedStamp` will always be there Commits ------- 67790f3 [Messenger] RejectRedeliveredMessageException should not be retried
diff --git a/src/Symfony/Component/Messenger/CHANGELOG.md b/src/Symfony/Component/Messenger/CHANGELOG.md
@@ -8,6 +8,7 @@ CHANGELOG
  * Add `HandlerDescriptor::getOptions`
  * Add support for multiple Redis Sentinel hosts
  * Add `--all` option to the `messenger:failed:remove` command
+ * `RejectRedeliveredMessageException` implements `UnrecoverableExceptionInterface` in order to not be retried
 
 6.3
 ---
diff --git a/src/Symfony/Component/Messenger/Exception/RejectRedeliveredMessageException.php b/src/Symfony/Component/Messenger/Exception/RejectRedeliveredMessageException.php
@@ -14,6 +14,6 @@
 /**
  * @author Tobias Schultze <http://tobion.de>
  */
-class RejectRedeliveredMessageException extends RuntimeException
+class RejectRedeliveredMessageException extends RuntimeException implements UnrecoverableExceptionInterface
 {
 }

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,6 @@`
`14`	`14`	`/**`
`15`	`15`	`* @author Tobias Schultze <http://tobion.de>`
`16`	`16`	`*/`
`17`		`-class RejectRedeliveredMessageException extends RuntimeException`
	`17`	`+class RejectRedeliveredMessageException extends RuntimeException implements UnrecoverableExceptionInterface`
`18`	`18`	`{`
`19`	`19`	`}`