8000 [WebServerBundle] tweaked command docs · symfony/symfony@585d445 · GitHub
[go: up one dir, main page]

Skip to content

Commit 585d445

Browse files
committed
[WebServerBundle] tweaked command docs
1 parent fa7ebc5 commit 585d445

File tree

3 files changed

+9
-18
lines changed

3 files changed

+9
-18
lines changed

src/Symfony/Bundle/WebServerBundle/Command/ServerRunCommand.php

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,22 +44,18 @@ protected function configure()
4444
4545
<info>%command.full_name%</info>
4646
47-
To change default bind address and port use the <info>address</info> argument:
47+
Change the default address and port by passing them as an argument:
4848
4949
<info>%command.full_name% 127.0.0.1:8080</info>
8000
5050
51-
To change default docroot directory use the <info>--docroot</info> option:
51+
Use the <info>--docroot</info> option to change the default docroot directory:
5252
5353
<info>%command.full_name% --docroot=htdocs/</info>
5454
55-
If you have custom docroot directory layout, you can specify your own
56-
router script using <info>--router</info> option:
55+
Specify your own router script via the <info>--router</info> option:
5756
5857
<info>%command.full_name% --router=app/config/router.php</info>
5958
60-
Specifing a router script is required when the used environment is not "dev",
61-
"prod", or "test".
62-
6359
See also: http://www.php.net/manual/en/features.commandline.webserver.php
6460
EOF
6561
)

src/Symfony/Bundle/WebServerBundle/Command/ServerStartCommand.php

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,22 +43,18 @@ protected function configure()
4343
4444
<info>php %command.full_name%</info>
4545
46-
To change the default bind address and the default port use the <info>address</info> argument:
46+
Change the default address and port by passing them as an argument:
4747
4848
<info>php %command.full_name% 127.0.0.1:8080</info>
4949
50-
To change the default document root directory use the <info>--docroot</info> option:
50+
Use the <info>--docroot</info> option to change the default docroot directory:
5151
5252
<info>php %command.full_name% --docroot=htdocs/</info>
5353
54-
If you have a custom document root directory layout, you can specify your own
55-
router script using the <info>--router</info> option:
54+
Specify your own router script via the <info>--router</info> option:
5655
5756
<info>php %command.full_name% --router=app/config/router.php</info>
5857
59-
Specifying a router script is required when the used environment is not <comment>"dev"</comment> or
60-
<comment>"prod"</comment>.
61-
6258
See also: http://www.php.net/manual/en/features.commandline.webserver.php
6359
EOF
6460
)

src/Symfony/Bundle/WebServerBundle/WebServer.php

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,14 +120,13 @@ public function start($router = null)
120120
$process->disableOutput();
121121
$process->start();
122122

123-
$lockFile = $this->getLockFile();
124-
touch($lockFile);
125-
126123
if (!$process->isRunning()) {
127-
unlink($lockFile);
128124
throw new \RuntimeException('Unable to start the server process.');
129125
}
130126

127+
$lockFile = $this->getLockFile();
128+
touch($lockFile);
129+
131130
// stop the web server when the lock file is removed
132131
while ($process->isRunning()) {
133132
if (!file_exists($lockFile)) {

0 commit comments

Comments
 (0)
0