8000 bug #43329 [Serializer] Respect default context in DateTimeNormalizer… · symfony/symfony@57e5141 · GitHub
[go: up one dir, main page]
Skip to content

Commit 57e5141

Browse files
nicolas-grekasnicolas-grekas
committed
bug #43329 [Serializer] Respect default context in DateTimeNormalizer::denormalize (hultberg)
This PR was merged into the 4.4 branch. Discussion ---------- [Serializer] Respect default context in DateTimeNormalizer::denormalize | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | yes | New feature? |no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #29030 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 5.x. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry --> Hey there. 👋 I'm bringing my first code patch to symfony today and it's for fixing a bug I encountered today while working with DateTimeNormalizer. In my project I have set a default date format in the service container and I noticed that the denormalized date did not follow my set date format (I enforce time but the serialized date did not contain the time stamp which should have failed when using DateTime::createFromDate). After some debugging I discovered the issue described in issue #29030 `DateTimeNormalizer::normalize` respects the date time format in context or default context while `DateTimeNormalizer::denormalize` only respects the former. This patch adds logic to denormalize too attempt create a DateTime object from the default context format (by default set to `\DateTime::RFC3339`) with createFromFormat and then if that fails continue on with the current behaviour. In my opinion this patch does not break the symfony BC promise as it simply adds another way to denormalize the date time. **One issue:** There are no error handling when creating the date time from default context as the logic just continues on which might give the impression to the developer that the denormalization with the specific format worked correctly. I was not able to find a way to handle any error and keeping BC. **Future tough:** At some point the `new DateTime` call in denormalize should be deprecated since creating a date time with createFromFormat is considered "safer" in my eyes as it's very explicit while the call to `new DateTime` is implicit about the date format and must perform parsing and guessing of the intended format (explained over at https://www.php.net/manual/en/datetime.formats.php). Another thing about `new DateTime` is the terriable error handling as you must catch a `\Exception` which means you catch "what ever" exception that can exist, even `\ErrorException` since `\ErrorException extends \Exception`. Fixes #29030 Alternative PR (closed) #33813 Commits ------- 763ea05 [Serializer] Respect default context in DateTimeNormalizer::denormalize
2 parents 9a4d7df + 763ea05 commit 57e5141

File tree

2 files changed

+32
-0
lines changed

2 files changed

+32
-0
lines changed

‎src/Symfony/Component/Serializer/Normalizer/DateTimeNormalizer.php

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,16 @@ public function denormalize($data, $type, $format = null, array $context = [])
113113
throw new NotNormalizableValueException(sprintf('Parsing datetime string "%s" using format "%s" resulted in %d errors: ', $data, $dateTimeFormat, $dateTimeErrors['error_count'])."\n".implode("\n", $this->formatDateTimeErrors($dateTimeErrors['errors'])));
114114
}
115115

116+
$defaultDateTimeFormat = $this->defaultContext[self::FORMAT_KEY] ?? null;
117+
118+
if (null !== $defaultDateTimeFormat) {
119+
$object = \DateTime::class === $type ? \DateTime::createFromFormat($defaultDateTimeFormat, $data, $timezone) : \DateTimeImmutable::createFromFormat($defaultDateTimeFormat, $data, $timezone);
120+
121+
if (false !== $object) {
122+
return $object;
123+
}
124+
}
125+
116126
try {
117127
return \DateTime::class === $type ? new \DateTime($data, $timezone) : new \DateTimeImmutable($data, $timezone);
118128
} catch (\Exception $e) {

‎src/Symfony/Component/Serializer/Tests/Normalizer/DateTimeNormalizerTest.php

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,28 @@ public function testDenormalizeDateTimeStringWithSpacesUsingFormatPassedInContex
305305
$this->normalizer->denormalize(' 2016.01.01 ', \DateTime::class, null, [DateTimeNormalizer::FORMAT_KEY => 'Y.m.d|']);
306306
}
307307

308+
public function testDenormalizeDateTimeStringWithDefaultContextFormat()
309+
{
310+
$format = 'd/m/Y';
311+
$string = '01/10/2018';
312+
313+
$normalizer = new DateTimeNormalizer([DateTimeNormalizer::FORMAT_KEY => $format]);
314+
$denormalizedDate = $normalizer->denormalize($string, \DateTimeInterface::class);
315+
316+
$this->assertSame('01/10/2018', $denormalizedDate->format($format));
317+
}
318+
319+
public function testDenormalizeDateTimeStringWithDefaultContextAllowsErrorFormat()
320+
{
321+
$format = 'd/m/Y'; // the default format
322+
$string = '2020-01-01'; // the value which is in the wrong format, but is accepted because of `new \DateTime` in DateTimeNormalizer::denormalize
323+
324+
$normalizer = new DateTimeNormalizer([DateTimeNormalizer::FORMAT_KEY => $format]);
325+
$denormalizedDate = $normalizer->denormalize($string, \DateTimeInterface::class);
326+
327+
$this->assertSame('2020-01-01', $denormalizedDate->format('Y-m-d'));
328+
}
329+
308330
public function testDenormalizeFormatMismatchThrowsException()
309331
{
310332
$this->expectException(UnexpectedValueException::class);

0 commit comments

Comments
 (0)
0