[Console] Allow 'false' as a $shortcut in InputOption.php

jayminsilicon · web-flow · commit 57ce3bb59b0e · 2024-01-31T21:26:55.000+05:30
This change is needed for laravel 8.x installation to allow running kernel and module based architecture. Right now our deployments are suddenly stopped since morning all saying "An option shortcut cannot be empty" and root cause for this is $shortcut is coming as false from laravel modules feature library.
diff --git a/src/Symfony/Component/Console/Input/InputOption.php b/src/Symfony/Component/Console/Input/InputOption.php
@@ -69,7 +69,7 @@ public function __construct(string $name, $shortcut = null, ?int $mode = null, s
             throw new InvalidArgumentException('An option name cannot be empty.');
         }
 
-        if ('' === $shortcut || [] === $shortcut) {
+        if ('' === $shortcut || [] === $shortcut || false === $shortcut) {
             $shortcut = null;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ public function __construct(string $name, $shortcut = null, ?int $mode = null, s`
`69`	`69`	`throw new InvalidArgumentException('An option name cannot be empty.');`
`70`	`70`	`}`
`71`	`71`
`72`		`- if ('' === $shortcut \|\| [] === $shortcut) {`
	`72`	`+ if ('' === $shortcut \|\| [] === $shortcut \|\| false === $shortcut) {`
`73`	`73`	`$shortcut = null;`
`74`	`74`	`}`
`75`	`75`